From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdg9Q-0001HL-1R for qemu-devel@nongnu.org; Thu, 12 Jul 2018 14:17:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdg9M-0006Zq-Fg for qemu-devel@nongnu.org; Thu, 12 Jul 2018 14:17:11 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48368 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fdg9M-0006Ym-9Z for qemu-devel@nongnu.org; Thu, 12 Jul 2018 14:17:08 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD59A81A4EA7 for ; Thu, 12 Jul 2018 18:17:07 +0000 (UTC) References: <20180712111221.20326-1-armbru@redhat.com> <20180712111221.20326-6-armbru@redhat.com> From: Thomas Huth Message-ID: <6e2dbaa9-8b12-581c-059a-3e1e86300202@redhat.com> Date: Thu, 12 Jul 2018 20:17:05 +0200 MIME-Version: 1.0 In-Reply-To: <20180712111221.20326-6-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org On 12.07.2018 13:12, Markus Armbruster wrote: > Commit ab45015a968 "qobject: Let qobject_from_jsonf() fail instead of > abort" removed only one of two ways qobject_from_jsonf() can abort. > Wrong. Wrong because it calls qobject_from_jsonv() with error_abort. Maybe mentioned that in the patch description - since it took me a while to understand what you mean here. Reviewed-by: Thomas Huth