From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Laurent Vivier <lvivier@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] bswap: Fix accessors syntax in comment
Date: Tue, 26 Feb 2019 19:36:13 +0100 [thread overview]
Message-ID: <6e2fa68d-2d4b-d0ee-bc03-c1cd1c7a8cc6@redhat.com> (raw)
In-Reply-To: <155119086741.1037569.12734854713022304642.stgit@bahia.lan>
On 2/26/19 3:21 PM, Greg Kurz wrote:
> All accessors that have an endian infix DO have an underscore between
> {size} and {endian}.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/qemu/bswap.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
> index a684c1a7a298..5a70f78c0ba4 100644
> --- a/include/qemu/bswap.h
> +++ b/include/qemu/bswap.h
> @@ -255,9 +255,9 @@ typedef union {
> /*
> * the generic syntax is:
> *
> - * load: ld{type}{sign}{size}{endian}_p(ptr)
> + * load: ld{type}{sign}{size}_{endian}_p(ptr)
> *
> - * store: st{type}{size}{endian}_p(ptr, val)
> + * store: st{type}{size}_{endian}_p(ptr, val)
> *
> * Note there are small differences with the softmmu access API!
> *
> @@ -293,10 +293,10 @@ typedef union {
> *
> * For cases where the size to be used is not fixed at compile time,
> * there are
> - * stn{endian}_p(ptr, sz, val)
> + * stn_{endian}_p(ptr, sz, val)
> * which stores @val to @ptr as an @endian-order number @sz bytes in size
> * and
> - * ldn{endian}_p(ptr, sz)
> + * ldn_{endian}_p(ptr, sz)
> * which loads @sz bytes from @ptr as an unsigned @endian-order number
> * and returns it in a uint64_t.
> */
>
>
next prev parent reply other threads:[~2019-02-26 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:21 [Qemu-devel] [PATCH] bswap: Fix accessors syntax in comment Greg Kurz
2019-02-26 17:18 ` Richard Henderson
2019-02-26 18:36 ` Philippe Mathieu-Daudé [this message]
2019-03-06 9:45 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e2fa68d-2d4b-d0ee-bc03-c1cd1c7a8cc6@redhat.com \
--to=philmd@redhat.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).