qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com, nsoffer@redhat.com,
	vsementsov@virtuozzo.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-4.0 00/14] nbd: add qemu-nbd --list
Date: Sat, 1 Dec 2018 07:57:51 -0600	[thread overview]
Message-ID: <6e32f97a-6b4c-2627-ed63-25d4c9f35eb3@redhat.com> (raw)
In-Reply-To: <20181201074244.GF27120@redhat.com>

On 12/1/18 1:42 AM, Richard W.M. Jones wrote:
> On Fri, Nov 30, 2018 at 04:03:29PM -0600, Eric Blake wrote:
>> I note that upstream NBD has 'nbd-client -l $host' for querying
>> just export names (with no quoting, so you have to know that
>> a blank line means the default export), but it wasn't powerful
>> enough, so I implemented 'qemu-nbd -L' to document everything.
>> Upstream NBD has separate 'nbd-client' and 'nbd-server' binaries,
>> while we only have 'qemu-nbd' (which is normally just a server,
>> but 'qemu-nbd -c' also operates a second thread as a client).
>> Our other uses of qemu as NBD client are for consuming a block
>> device (as in qemu-io, qemu-img, or a drive to qemu) - but those
>> binaries are less suited to something so specific to the NBD
>> protocol.
> 
> I tried it against nbdkit and it works (obviously):
> 
> $ ./qemu-nbd -L
> exports available: 1
>   export: ''
>    size:  67108864
>    flags: 0x61 ( trim zeroes )
> 
> What I couldn't work out is how to connect to other hosts.  It's
> possible to add -p or -k to change the localhost port number or to use
> a Unix domain socket (and I checked both work).  However can we
> connect to remote hosts?

Should work by adding '-b host' (if -b is omitted, it defaults to 
0.0.0.0).  However, I admit that so far I have only tested '-b 
localhost' or '-b 127.0.0.1' (per the iotest additions at the end of the 
series), so it could well be something that I missed in setting up the 
client socket in nbd_build_socket_address().

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-12-01 13:58 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 22:03 [Qemu-devel] [PATCH for-4.0 00/14] nbd: add qemu-nbd --list Eric Blake
2018-11-30 22:03 ` [Qemu-devel] [PATCH 01/14] qemu-nbd: Use program name in error messages Eric Blake
2018-11-30 22:17   ` Richard W.M. Jones
2018-12-05 14:55   ` Vladimir Sementsov-Ogievskiy
2018-11-30 22:03 ` [Qemu-devel] [PATCH 02/14] nbd/client: More consistent " Eric Blake
2018-11-30 22:20   ` Richard W.M. Jones
2018-12-05 15:03   ` Vladimir Sementsov-Ogievskiy
2018-12-10 22:03     ` Eric Blake
2018-11-30 22:03 ` [Qemu-devel] [PATCH 03/14] qemu-nbd: Fail earlier for -c/-d on non-linux Eric Blake
2018-11-30 22:23   ` Richard W.M. Jones
2018-12-05 15:20   ` Vladimir Sementsov-Ogievskiy
2018-11-30 22:03 ` [Qemu-devel] [PATCH 04/14] qemu-nbd: Simplify --partition handling Eric Blake
2018-11-30 22:26   ` Richard W.M. Jones
2018-11-30 22:41     ` Eric Blake
2018-12-05 15:40   ` Vladimir Sementsov-Ogievskiy
2018-12-05 16:26     ` Eric Blake
2018-12-05 16:32       ` Eric Blake
2018-12-10 22:28   ` Eric Blake
2018-11-30 22:03 ` [Qemu-devel] [PATCH 05/14] nbd/client: Drop pointless buf variable Eric Blake
2018-11-30 22:30   ` Richard W.M. Jones
2018-11-30 22:54     ` Eric Blake
2018-12-05 15:59   ` Vladimir Sementsov-Ogievskiy
2018-12-05 16:29     ` Eric Blake
2018-12-05 16:38       ` Vladimir Sementsov-Ogievskiy
2018-12-05 16:49         ` Eric Blake
2018-11-30 22:03 ` [Qemu-devel] [PATCH 06/14] nbd/client: Move export name into NBDExportInfo Eric Blake
2018-11-30 22:34   ` Richard W.M. Jones
2018-12-05 17:26   ` Vladimir Sementsov-Ogievskiy
2018-11-30 22:03 ` [Qemu-devel] [PATCH 07/14] nbd/client: Refactor nbd_negotiate_simple_meta_context() Eric Blake
2018-12-01 10:30   ` Richard W.M. Jones
2018-12-06 13:20   ` Vladimir Sementsov-Ogievskiy
2018-12-06 16:20     ` Eric Blake
2018-11-30 22:03 ` [Qemu-devel] [PATCH 08/14] nbd/client: Refactor nbd_receive_list() Eric Blake
2018-12-01 10:37   ` Richard W.M. Jones
2018-12-06 14:18   ` Vladimir Sementsov-Ogievskiy
2018-12-06 16:31     ` Eric Blake
2018-12-06 17:03       ` Vladimir Sementsov-Ogievskiy
2018-11-30 22:03 ` [Qemu-devel] [PATCH 09/14] nbd/client: Refactor return of nbd_receive_negotiate() Eric Blake
2018-11-30 22:41   ` Richard W.M. Jones
2018-12-06 14:24   ` Vladimir Sementsov-Ogievskiy
2018-11-30 22:03 ` [Qemu-devel] [PATCH 10/14] nbd/client: Split handshake into two functions Eric Blake
2018-12-01 10:41   ` Richard W.M. Jones
2018-12-06 15:16   ` Vladimir Sementsov-Ogievskiy
2018-12-06 17:06     ` Vladimir Sementsov-Ogievskiy
2018-11-30 22:03 ` [Qemu-devel] [PATCH 11/14] nbd/client: Add nbd_receive_export_list() Eric Blake
2018-12-01 10:45   ` Richard W.M. Jones
2018-12-07 10:04   ` Vladimir Sementsov-Ogievskiy
2018-12-07 15:19     ` Eric Blake
2018-12-07 10:07   ` Vladimir Sementsov-Ogievskiy
2018-11-30 22:03 ` [Qemu-devel] [PATCH 12/14] nbd/client: Work around 3.0 bug for listing meta contexts Eric Blake
2018-12-07 11:21   ` Vladimir Sementsov-Ogievskiy
2018-12-07 15:21     ` Eric Blake
2018-11-30 22:03 ` [Qemu-devel] [PATCH 13/14] qemu-nbd: Add --list option Eric Blake
2018-12-01 10:58   ` Richard W.M. Jones
2018-12-07 12:48   ` Vladimir Sementsov-Ogievskiy
2018-12-07 15:36     ` Eric Blake
2018-12-07 16:49       ` Vladimir Sementsov-Ogievskiy
2018-12-07 16:49       ` Vladimir Sementsov-Ogievskiy
2018-12-07 16:59         ` Eric Blake
2018-11-30 22:03 ` [Qemu-devel] [PATCH 14/14] iotests: Enhance 223, 233 to cover 'qemu-nbd --list' Eric Blake
2018-12-01 11:04   ` Richard W.M. Jones
2018-12-07 13:08   ` Vladimir Sementsov-Ogievskiy
2018-12-01  7:42 ` [Qemu-devel] [PATCH for-4.0 00/14] nbd: add qemu-nbd --list Richard W.M. Jones
2018-12-01 13:57   ` Eric Blake [this message]
2018-12-01 15:00     ` Richard W.M. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e32f97a-6b4c-2627-ed63-25d4c9f35eb3@redhat.com \
    --to=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=nsoffer@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).