qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets
@ 2018-11-29  3:12 Jason Wang
  2018-11-29  3:12 ` [Qemu-devel] [PATCH for 3.1 1/4] net: drop too large packet early Jason Wang
                   ` (5 more replies)
  0 siblings, 6 replies; 14+ messages in thread
From: Jason Wang @ 2018-11-29  3:12 UTC (permalink / raw)
  To: qemu-devel, peter.maydell
  Cc: mst, ppandit, liq3ea, liq3ea, pbonzini, Jason Wang

Hi:

This series tries to fix a possible OOB during queueing packets
through qemu_net_queue_append_iov(). This could happen when it tries
to queue a packet whose size is larger than INT_MAX which may lead
integer overflow. We've fixed similar issue in the past during
qemu_net_queue_deliver_iov() by ignoring large packets there. Let's
just move the check earlier to qemu_sendv_packet_async() and reduce
the limitation to NET_BUFSIZE. A simple qtest were also added this.

Please review.

Thanks

Jason Wang (4):
  net: drop too large packet early
  virtio-net-test: remove unused macro
  virtio-net-test: accept variable length argument in pci_test_start()
  virtio-net-test: add large tx buffer test

 net/net.c               | 13 +++++----
 tests/virtio-net-test.c | 64 ++++++++++++++++++++++++++++++++++++-----
 2 files changed, 64 insertions(+), 13 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2018-12-03 10:08 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-29  3:12 [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets Jason Wang
2018-11-29  3:12 ` [Qemu-devel] [PATCH for 3.1 1/4] net: drop too large packet early Jason Wang
2018-11-29  3:43   ` Li Qiang
2018-11-29  3:12 ` [Qemu-devel] [PATCH for 3.1 2/4] virtio-net-test: remove unused macro Jason Wang
2018-11-29  6:17   ` Thomas Huth
2018-11-29  3:12 ` [Qemu-devel] [PATCH for 3.1 3/4] virtio-net-test: accept variable length argument in pci_test_start() Jason Wang
2018-11-29  6:16   ` Thomas Huth
2018-11-30 15:02   ` Eric Blake
2018-12-03 10:08     ` Jason Wang
2018-11-29  3:12 ` [Qemu-devel] [PATCH for 3.1 4/4] virtio-net-test: add large tx buffer test Jason Wang
2018-11-29  6:21   ` Thomas Huth
2018-11-29 12:15     ` Jason Wang
2018-11-30  3:48 ` [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets no-reply
2018-11-30  3:49 ` no-reply

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).