Re: [Qemu-devel] [PATCH] scripts/dump-qcow2.pl: Script to dump qcow2 metadata

[Max Reitz <mreitz@redhat.com>]

On 2018-03-28 15:38, Alberto Garcia wrote:
> This script takes a qcow2 image and dumps its metadata: header,
> snapshot table and some extensions (although not all qcow2 features
> are supported yet).
> 
> It can also display a list of all host clusters and the guest -> host
> address mappings, so it's useful to debug allocations.
> 
> The image is assumed not to be corrupted, and this script does not do
> consistency checks (yet).
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  scripts/dump-qcow2.pl | 425 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 425 insertions(+)
>  create mode 100755 scripts/dump-qcow2.pl

First of all: The main reason I haven't reviewed this so far is because
I don't like Perl.

OK, now that that's out of the way...  I'm wondering why you want to add
this to the qemu tree?  If you'd written an iotest that would make use
of it, sure.  But if it's just for debugging, then I'd personally think
it would be better to just add it to a private repository.  That would
give you more freedom to extend it, too.

(I know John has an own script for debugging qcow2 images.)

Of course the nice thing about putting it into the qemu repository would
be that people would be able to find it.  But then again, we could
probably achieve the same with a Wiki page.

Max