From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Willian Rampazzo <willianr@redhat.com>,
Thomas Huth <thuth@redhat.com>,
berrange@redhat.com,
Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: Re: [RFC PATCH] scripts/checkpatch: roll diff tweaking into checkpatch itself
Date: Tue, 8 Jun 2021 08:35:42 +0200 [thread overview]
Message-ID: <6e4a4fed-a6b2-4e2d-b40f-5f0910bace0d@redhat.com> (raw)
In-Reply-To: <20210607171829.25111-1-alex.bennee@linaro.org>
On 6/7/21 7:18 PM, Alex Bennée wrote:
> Rather than relying on external tweaks lets just do it inside
> checkpatch's direct commitish handling which is QEMU specific code
> anyway.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.d/static_checks.yml | 3 ---
> .patchew.yml | 3 ---
> scripts/checkpatch.pl | 7 ++++++-
> 3 files changed, 6 insertions(+), 7 deletions(-)
Clever.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-06-08 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 17:18 [RFC PATCH] scripts/checkpatch: roll diff tweaking into checkpatch itself Alex Bennée
2021-06-07 17:29 ` Daniel P. Berrangé
2021-06-07 18:07 ` Willian Rampazzo
2021-06-08 6:35 ` Philippe Mathieu-Daudé [this message]
2021-06-08 12:52 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e4a4fed-a6b2-4e2d-b40f-5f0910bace0d@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).