From: Thomas Huth <thuth@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Stefan Weil" <sw@weilnetz.de>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Joel Stanley" <joel@jms.id.au>,
"Laurent Vivier" <lvivier@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
qemu-arm@nongnu.org, "Stefan Berger" <stefanb@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/4] tests: use closesocket()
Date: Mon, 13 Feb 2023 09:03:06 +0100 [thread overview]
Message-ID: <6e4c4982-4865-8237-0dd1-a187d0ab757a@redhat.com> (raw)
In-Reply-To: <20230212204942.1905959-2-marcandre.lureau@redhat.com>
On 12/02/2023 21.49, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Because they are actually sockets...
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/unit/socket-helpers.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/unit/socket-helpers.c b/tests/unit/socket-helpers.c
> index eecadf3a3c..914b3aa0cf 100644
> --- a/tests/unit/socket-helpers.c
> +++ b/tests/unit/socket-helpers.c
> @@ -117,13 +117,13 @@ static int socket_can_bind_connect(const char *hostname, int family)
>
> cleanup:
> if (afd != -1) {
> - close(afd);
> + closesocket(afd);
> }
> if (cfd != -1) {
> - close(cfd);
> + closesocket(cfd);
> }
> if (lfd != -1) {
> - close(lfd);
> + closesocket(lfd);
> }
> if (res) {
> freeaddrinfo(res);
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-02-13 8:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 20:49 [PATCH 0/4] win32: do not mix SOCKET and fd space marcandre.lureau
2023-02-12 20:49 ` [PATCH 1/4] tests: use closesocket() marcandre.lureau
2023-02-13 8:03 ` Thomas Huth [this message]
2023-02-12 20:49 ` [PATCH 2/4] io: " marcandre.lureau
2023-02-13 8:04 ` Thomas Huth
2023-02-12 20:49 ` [PATCH 3/4] win32: stop mixing SOCKET and file descriptor space marcandre.lureau
2023-02-20 11:27 ` Marc-André Lureau
2023-02-20 12:38 ` Markus Armbruster
2023-02-20 15:29 ` Marc-André Lureau
2023-02-20 15:58 ` Daniel P. Berrangé
2023-02-21 8:18 ` Paolo Bonzini
2023-02-21 9:12 ` Marc-André Lureau
2023-02-21 10:40 ` Marc-André Lureau
2023-02-21 10:52 ` Paolo Bonzini
2023-02-12 20:49 ` [PATCH 4/4] win32: replace closesocket() with close() wrapper marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e4c4982-4865-8237-0dd1-a187d0ab757a@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).