From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>,
rad@semihalf.com, peter.maydell@linaro.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Cc: quic_llindhol@quicinc.com, chenbaozi@phytium.com.cn
Subject: Re: [PATCH 1/1] hw/arm/sbsa-ref: set 'slots' property of xhci
Date: Mon, 10 Jul 2023 09:34:58 +0200 [thread overview]
Message-ID: <6e4d44f9-55d5-b9e9-871f-ac47b7e43f1d@linaro.org> (raw)
In-Reply-To: <20230710063750.473510-2-wangyuquan1236@phytium.com.cn>
W dniu 10.07.2023 o 08:37, Yuquan Wang pisze:
> This extends the slots of xhci to 64, since the default xhci_sysbus
> just supports one slot.
>
> Signed-off-by: Wang Yuquan <wangyuquan1236@phytium.com.cn>
> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
> ---
> hw/arm/sbsa-ref.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 64e1cbce17..bc89eb4806 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -611,6 +611,7 @@ static void create_xhci(const SBSAMachineState *sms)
> hwaddr base = sbsa_ref_memmap[SBSA_XHCI].base;
> int irq = sbsa_ref_irqmap[SBSA_XHCI];
> DeviceState *dev = qdev_new(TYPE_XHCI_SYSBUS);
> + qdev_prop_set_uint32(dev, "slots", XHCI_MAXSLOTS);
Looks like tab instead of spaces.
>
> sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
> sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
Tested-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Reviewed-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Before:
xhci-hcd PNP0D10:00: Error while assigning device slot ID: No Slots Available Error
xhci-hcd PNP0D10:00: Max number of devices this xHCI host supports is 1.
usb usb1-port2: couldn't allocate usb_device
After:
input: QEMU QEMU USB Keyboard as /devices/platform/PNP0D10:00/usb1/1-1/1-1:1.0/0003:0627:0001.0001/input/input0
hid-generic 0003:0627:0001.0001: input,hidraw0: USB HID v1.11 Keyboard [QEMU QEMU USB Keyboard] on usb-PNP0D10:00-1/input0
input: QEMU QEMU USB Tablet as /devices/platform/PNP0D10:00/usb1/1-2/1-2:1.0/0003:0627:0001.0002/input/input1
hid-generic 0003:0627:0001.0002: input,hidraw1: USB HID v0.01 Mouse [QEMU QEMU USB Tablet] on usb-PNP0D10:00-2/input0
next prev parent reply other threads:[~2023-07-10 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 6:37 [PATCH 0/1] hw/arm/sbsa-ref: set 'slots' property of xhci Yuquan Wang
2023-07-10 6:37 ` [PATCH 1/1] " Yuquan Wang
2023-07-10 7:28 ` Richard Henderson
2023-07-10 7:33 ` Marcin Juszkiewicz
2023-07-10 8:14 ` Richard Henderson
2023-07-10 10:17 ` Philippe Mathieu-Daudé
2023-07-10 7:34 ` Marcin Juszkiewicz [this message]
2023-07-13 11:39 ` [PATCH 0/1] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e4d44f9-55d5-b9e9-871f-ac47b7e43f1d@linaro.org \
--to=marcin.juszkiewicz@linaro.org \
--cc=chenbaozi@phytium.com.cn \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).