From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] List of files containing devices which have not been QOMified
Date: Fri, 9 Nov 2018 14:16:53 +0100 [thread overview]
Message-ID: <6e7304f6-b81a-982f-a94c-d8df4202a82e@redhat.com> (raw)
In-Reply-To: <1724064a-acdc-5571-4f54-f0ac021027d0@redhat.com>
On 09/11/2018 13:39, Thomas Huth wrote:
> On 2018-11-09 12:29, Gerd Hoffmann wrote:
>> On Fri, Nov 09, 2018 at 12:17:31PM +0100, Gerd Hoffmann wrote:
>>> Hi,
>>>
>>>> I am also suspicious about hw/bt/ but don't know enough
>>>> about that subsystem to say if it could benefit from
>>>> using QOM objects more.
>>>
>>> I'm wondering whenever anyone would even notice if we just rm -rf hw/bt
>>>
>>> Looking through the changelog for the last five years (after hw/ split)
>>> the only thing I see is fixing warnings from compiler or coverity,
>>> adapting to changes in other systems (chardev for example) and treewide
>>> changes. Not a *single* patch specific to bluetooth ...
>>
>> Tried this after studying docs:
>>
>> qemu -usb -device usb-bt-dongle -bt hci,vlan=0 -bt device:keyboard
>>
>> Segfaults right anway on first keypress.
>> I guess that qualifies as "broken and obviously unused".
>
> Thanks for checking! I guess that means we could even get rid of it
> without deprecating it first if it is broken already for more than two
> releases...?
I think what others were using bluetooth passthrough. But it's
certainly possible that it's broken.
Paolo
next prev parent reply other threads:[~2018-11-09 13:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 18:43 [Qemu-devel] List of files containing devices which have not been QOMified Peter Maydell
2018-11-06 19:16 ` Philippe Mathieu-Daudé
2018-11-06 23:06 ` Peter Maydell
2018-11-07 15:22 ` Philippe Mathieu-Daudé
2018-11-06 19:43 ` Paolo Bonzini
2018-11-06 19:46 ` Paolo Bonzini
2018-11-06 19:51 ` Alistair Francis
2018-11-06 21:23 ` John Snow
2018-11-06 21:26 ` Paolo Bonzini
2018-11-06 23:05 ` Peter Maydell
2018-11-06 23:09 ` Paolo Bonzini
2018-11-07 18:53 ` Palmer Dabbelt
2018-11-09 10:17 ` Mark Cave-Ayland
2018-11-09 10:31 ` Peter Maydell
2018-11-10 15:20 ` Mark Cave-Ayland
2018-11-12 10:57 ` Peter Maydell
2018-11-09 11:17 ` Gerd Hoffmann
2018-11-09 11:29 ` Gerd Hoffmann
2018-11-09 12:39 ` Thomas Huth
2018-11-09 12:44 ` Peter Maydell
2018-11-09 13:16 ` Paolo Bonzini [this message]
2018-11-09 14:03 ` [Qemu-devel] deprecating/removing bluetooth (was: Re: List of files containing devices which have not been QOMified) Gerd Hoffmann
2018-11-12 8:51 ` [Qemu-devel] List of files containing devices which have not been QOMified Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e7304f6-b81a-982f-a94c-d8df4202a82e@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).