Re: [PATCH] hw/sysbus: Inline and remove sysbus_add_io()

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 16/2/24 16:04, Philippe Mathieu-Daudé wrote:
> sysbus_add_io(...) is a simple wrapper to
> memory_region_add_subregion(get_system_io(), ...).
> It is used in 3 places; inline it directly.

Rationale here is we want to move to an explicit I/O bus,
rather that an implicit one. Besides in heterogeneous
setup we can have more than one I/O bus.

> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/sysbus.h | 2 --
>   hw/core/sysbus.c    | 6 ------
>   hw/i386/kvmvapic.c  | 2 +-
>   hw/mips/mipssim.c   | 2 +-
>   hw/nvram/fw_cfg.c   | 5 +++--
>   5 files changed, 5 insertions(+), 12 deletions(-)
> 
> diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
> index 3564b7b6a2..14dbc22d0c 100644
> --- a/include/hw/sysbus.h
> +++ b/include/hw/sysbus.h
> @@ -83,8 +83,6 @@ void sysbus_mmio_map(SysBusDevice *dev, int n, hwaddr addr);
>   void sysbus_mmio_map_overlap(SysBusDevice *dev, int n, hwaddr addr,
>                                int priority);
>   void sysbus_mmio_unmap(SysBusDevice *dev, int n);
> -void sysbus_add_io(SysBusDevice *dev, hwaddr addr,
> -                   MemoryRegion *mem);
>   MemoryRegion *sysbus_address_space(SysBusDevice *dev);