From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1c18vY-0002cr-OV
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 05:30:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1c18vV-0004ju-NQ
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 05:30:48 -0400
Received: from mga04.intel.com ([192.55.52.120]:29451)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <guangrong.xiao@linux.intel.com>)
	id 1c18vV-0004in-Ey
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 05:30:45 -0400
References: <1477850917-1214-1-git-send-email-mst@redhat.com>
	<1477850917-1214-31-git-send-email-mst@redhat.com>
	<20161031102032.0eb037b3@nial.brq.redhat.com>
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Message-ID: <6e873b38-715d-c9e5-9750-adaa88a00ba1@linux.intel.com>
Date: Mon, 31 Oct 2016 17:23:31 +0800
MIME-Version: 1.0
In-Reply-To: <20161031102032.0eb037b3@nial.brq.redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 30/47] acpi nvdimm: fix device physical
 address base
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>



On 10/31/2016 05:20 PM, Igor Mammedov wrote:
> On Sun, 30 Oct 2016 23:24:46 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>>
>> According to ACPI 6.0  spec, "Memory Device Physical Address
>> Region Base" in memdev is defined as "This field provides the
>> Device Physical Address base of the region". This field should
>> be zero in our case
> I'm not sure that it should be a zero,
> care to point source which tells that it should be zero?

The spec says that this is the Device Physical Address, so that
it is the device internal address, it should be zero as we do not
reserve any thing in device internal and we do not have no memory
interleave.

Actually, this bug was exported when we were enabling nvdimm in
windows guest.