From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: Functional tests precache behaviour
Date: Wed, 30 Apr 2025 08:48:59 -0700 [thread overview]
Message-ID: <6e9a3cb3-e238-48a7-a67c-c95b36a517bc@linaro.org> (raw)
In-Reply-To: <7f0c4586-8a97-4e64-8abb-58a74b86afaa@redhat.com>
On 4/30/25 8:00 AM, Thomas Huth wrote:
> On 30/04/2025 16.34, Pierrick Bouvier wrote:
>> Hi folks,
>>
>> $ ninja -C build precache-functional
>> 2025-04-30 07:23:20,382 - qemu-test - ERROR - Unable to download https://
>> archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/
>> gzimg/armv7.img.gz: HTTP error 503
>> 2025-04-30 07:23:23,131 - qemu-test - ERROR - Unable to download https://
>> archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/
>> gzimg/armv7.img.gz: HTTP error 503
>> 2025-04-30 07:23:25,870 - qemu-test - ERROR - Unable to download https://
>> archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/
>> gzimg/armv7.img.gz: HTTP error 503
>> 2025-04-30 07:23:25,871 - qemu-test - ERROR - https://archive.netbsd.org/
>> pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz:
>> Download retries exceeded: skipping asset precache
>> $ echo $?
>> 0
>>
>> Since we silently skip the asset precaching, how can we identify that an
>> asset is not available anymore (temporarily or not)?
>> Should we rely on test itself failing when trying to download again this asset?
>
> The current logic fails hard for 404 errors, so if the asset is completely
> gone, we should notice it. For other error codes, we assume that it is only
> a temporary server problem that will hopefully be fixed on the server side
> sooner or later.
>
Sounds good.
Should we replicate this semantic when running the test itself?
It would be more useful to skip it because an asset is missing instead
of reporting an error, except if it's a 404 error.
> Thomas
>
next prev parent reply other threads:[~2025-04-30 15:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 14:34 Functional tests precache behaviour Pierrick Bouvier
2025-04-30 15:00 ` Thomas Huth
2025-04-30 15:48 ` Pierrick Bouvier [this message]
2025-04-30 16:02 ` Daniel P. Berrangé
2025-04-30 16:21 ` Pierrick Bouvier
2025-04-30 16:29 ` Daniel P. Berrangé
2025-04-30 16:34 ` Pierrick Bouvier
2025-04-30 16:39 ` Daniel P. Berrangé
2025-04-30 16:46 ` Pierrick Bouvier
2025-05-01 17:56 ` Peter Maydell
2025-05-01 21:26 ` Pierrick Bouvier
2025-05-03 20:21 ` Pierrick Bouvier
2025-04-30 16:22 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e9a3cb3-e238-48a7-a67c-c95b36a517bc@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).