From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C438C04FFE for ; Fri, 26 Apr 2024 14:33:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0MdN-000891-Jd; Fri, 26 Apr 2024 10:33:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0MdK-00088Q-Oi; Fri, 26 Apr 2024 10:33:03 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0MdI-0003z6-Py; Fri, 26 Apr 2024 10:33:02 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4VQwDp2SCpz4xG1; Sat, 27 Apr 2024 00:32:58 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4VQwDl45Qkz4wnv; Sat, 27 Apr 2024 00:32:55 +1000 (AEST) Message-ID: <6ea2dbd5-46d3-44d9-bab3-175d38b85a74@kaod.org> Date: Fri, 26 Apr 2024 16:32:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/10] ppc/pnv: Add a LPC controller for POWER11 To: Aditya Gupta , Mahesh J Salgaonkar , Madhavan Srinivasan , Nicholas Piggin Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= References: <20240426110023.733309-1-adityag@linux.ibm.com> <20240426110023.733309-6-adityag@linux.ibm.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <20240426110023.733309-6-adityag@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=oYEp=L7=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/26/24 13:00, Aditya Gupta wrote: > Power11 core is same as Power10 core, declare PNV11_LPC as a child > class of PNV10_LPC, so it goes through same class init > > Cc: Cédric Le Goater > Cc: Frédéric Barrat > Cc: Mahesh J Salgaonkar > Cc: Madhavan Srinivasan > Cc: Nicholas Piggin > Signed-off-by: Aditya Gupta Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/ppc/pnv_lpc.c | 14 ++++++++++++++ > include/hw/ppc/pnv_lpc.h | 4 ++++ > 2 files changed, 18 insertions(+) > > diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c > index d692858bee78..54b366221bc7 100644 > --- a/hw/ppc/pnv_lpc.c > +++ b/hw/ppc/pnv_lpc.c > @@ -698,6 +698,19 @@ static const TypeInfo pnv_lpc_power10_info = { > .class_init = pnv_lpc_power10_class_init, > }; > > +static void pnv_lpc_power11_class_init(ObjectClass *klass, void *data) > +{ > + DeviceClass *dc = DEVICE_CLASS(klass); > + > + dc->desc = "PowerNV LPC Controller POWER11"; > +} > + > +static const TypeInfo pnv_lpc_power11_info = { > + .name = TYPE_PNV11_LPC, > + .parent = TYPE_PNV10_LPC, > + .class_init = pnv_lpc_power11_class_init, > +}; > + > static void pnv_lpc_realize(DeviceState *dev, Error **errp) > { > PnvLpcController *lpc = PNV_LPC(dev); > @@ -771,6 +784,7 @@ static void pnv_lpc_register_types(void) > type_register_static(&pnv_lpc_power8_info); > type_register_static(&pnv_lpc_power9_info); > type_register_static(&pnv_lpc_power10_info); > + type_register_static(&pnv_lpc_power11_info); > } > > type_init(pnv_lpc_register_types) > diff --git a/include/hw/ppc/pnv_lpc.h b/include/hw/ppc/pnv_lpc.h > index 5d22c4557041..1069bca38dfd 100644 > --- a/include/hw/ppc/pnv_lpc.h > +++ b/include/hw/ppc/pnv_lpc.h > @@ -41,6 +41,10 @@ DECLARE_INSTANCE_CHECKER(PnvLpcController, PNV9_LPC, > DECLARE_INSTANCE_CHECKER(PnvLpcController, PNV10_LPC, > TYPE_PNV10_LPC) > > +#define TYPE_PNV11_LPC TYPE_PNV_LPC "-POWER11" > +DECLARE_INSTANCE_CHECKER(PnvLpcController, PNV11_LPC, > + TYPE_PNV11_LPC) > + > struct PnvLpcController { > DeviceState parent; >