From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6JHm-0001qF-Ev for qemu-devel@nongnu.org; Fri, 27 May 2016 11:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6JHg-0000GX-LT for qemu-devel@nongnu.org; Fri, 27 May 2016 11:02:50 -0400 References: <1464338922-13102-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1464338922-13102-3-git-send-email-mark.cave-ayland@ilande.co.uk> From: John Snow Message-ID: <6ecc4f1a-5dd3-7567-51b4-52bdb937c0c9@redhat.com> Date: Fri, 27 May 2016 11:02:41 -0400 MIME-Version: 1.0 In-Reply-To: <1464338922-13102-3-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] macio: switch over to new byte-aligned DMA helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com, aurelien@aurel32.net On 05/27/2016 04:48 AM, Mark Cave-Ayland wrote: > Now that the DMA helpers are byte-aligned they can be called directly from > the macio routines rather than emulating byte-aligned accesses via multiple > block-level accesses. > > Signed-off-by: Mark Cave-Ayland > --- > hw/ide/macio.c | 213 ++++++++------------------------------------------------ ^ _cool_ ^ I assume you'll actually not be needing me to deal with this until you resolve the HACK in the pre-requisite patch, yes? > 1 file changed, 28 insertions(+), 185 deletions(-) > > diff --git a/hw/ide/macio.c b/hw/ide/macio.c > index 42ad68a..e4e567e 100644 > --- a/hw/ide/macio.c > +++ b/hw/ide/macio.c > @@ -52,187 +52,6 @@ static const int debug_macio = 0; > > #define MACIO_PAGE_SIZE 4096 >