From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOWAQ-0001Vv-Iq for qemu-devel@nongnu.org; Mon, 11 Dec 2017 17:03:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOWAN-0000C3-Gj for qemu-devel@nongnu.org; Mon, 11 Dec 2017 17:03:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60786) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOWAN-0000AP-3u for qemu-devel@nongnu.org; Mon, 11 Dec 2017 17:03:15 -0500 References: <20171208105553.12249-1-pbonzini@redhat.com> <20171208105553.12249-6-pbonzini@redhat.com> <20171208151306.GC8998@stefanha-x1.localdomain> <9c90d2b3-242e-5ffc-3e48-cf05e6fe85c3@redhat.com> <20171211102304.GC13593@stefanha-x1.localdomain> From: Paolo Bonzini Message-ID: <6ed2a5cd-cb82-29e9-a2a8-be4a848fa34b@redhat.com> Date: Mon, 11 Dec 2017 23:03:02 +0100 MIME-Version: 1.0 In-Reply-To: <20171211102304.GC13593@stefanha-x1.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AN70E5V7he5q2b5xGfpOBbRJEklpTLVq2" Subject: Re: [Qemu-devel] [PATCH 5/5] thread-pool: convert to use lock guards List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Eric Blake Cc: "Emilio G . Cota" , Fam Zheng , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AN70E5V7he5q2b5xGfpOBbRJEklpTLVq2 From: Paolo Bonzini To: Stefan Hajnoczi , Eric Blake Cc: "Emilio G . Cota" , Fam Zheng , qemu-devel@nongnu.org Message-ID: <6ed2a5cd-cb82-29e9-a2a8-be4a848fa34b@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/5] thread-pool: convert to use lock guards References: <20171208105553.12249-1-pbonzini@redhat.com> <20171208105553.12249-6-pbonzini@redhat.com> <20171208151306.GC8998@stefanha-x1.localdomain> <9c90d2b3-242e-5ffc-3e48-cf05e6fe85c3@redhat.com> <20171211102304.GC13593@stefanha-x1.localdomain> In-Reply-To: <20171211102304.GC13593@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/12/2017 11:23, Stefan Hajnoczi wrote: >> >> In other words, I don't see what 'QEMU_WITH_LOCK_GUARD() {}' buys us >> over '{ QEMU_LOCK_GUARD() }'. > The QEMU_WITH_LOCK_GUARD() {} syntax is nice because it's similar to > if/while/for statements. >=20 > However, { QEMU_LOCK_GUARD() } doesn't hide a for statement in a macro > so the break statement works inside the scope. Less chance of bugs. The same is true of a "switch" statement. Being able to break out of QEMU_WITH_LOCK_GUARD could also be a feature... Paolo > I'd be okay without QEMU_WITH_LOCK_GUARD(). --AN70E5V7he5q2b5xGfpOBbRJEklpTLVq2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAlovAJYACgkQv/vSX3jH roOQVggAm3lOBcXnBipKHWDgQ8qdShqQrdJ5PUcu5f2Xa+WdjaNtFmjPydJ/irLn hCIntkQ5eZ6+d7aDAZtde5O5jl8DwT7stHn7hrhh4bhLcmrkURyQF6Kw39BhE5F0 bprxu4MyeXMO6HLg1D7UXdQXDZLCE53AHCKtjpxf0bAKGtTnlb0i7UmZfn1KXYDU zh8JOd30gGzF84BCO6KUbEm4v0HakJeUkw+KEiTEBcZQJjKz47/kxnuyZHorbdSA +z1aDEFTDccApNHWwWi/dH+Ctg4fxvoLRsLCQ3BwtLxvMtazpZE7CpBt2SIRlhM6 /vnsCJEtOp0y+JBzBkmB/jwDXBXlRQ== =z/0Z -----END PGP SIGNATURE----- --AN70E5V7he5q2b5xGfpOBbRJEklpTLVq2--