From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euL13-0007Hp-DC for qemu-devel@nongnu.org; Fri, 09 Mar 2018 11:37:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euL12-0006v0-GE for qemu-devel@nongnu.org; Fri, 09 Mar 2018 11:37:09 -0500 References: <20180309153347.62552-1-vsementsov@virtuozzo.com> <8654ed9f-14bd-4e36-0df0-5eff5fccdb7a@virtuozzo.com> From: Eric Blake Message-ID: <6ed49ea1-af9d-bfb5-12b5-97c1f1bb6f22@redhat.com> Date: Fri, 9 Mar 2018 10:37:00 -0600 MIME-Version: 1.0 In-Reply-To: <8654ed9f-14bd-4e36-0df0-5eff5fccdb7a@virtuozzo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 0/2] block latency histogram List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: armbru@redhat.com, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, nshirokovskiy@virtuozzo.com On 03/09/2018 10:31 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.03.2018 18:40, Eric Blake wrote: >> On 03/09/2018 09:33 AM, Vladimir Sementsov-Ogievskiy wrote: >>> v4: >>> >>> Move block_latency_histogram_set from block/accounting.c to >>> blockdev.c, as it uses qapi type uint64List and this fact breaks >>> build. >> >> Was the cross file motion necessary, or could you just fix the=20 >> #includes according to the recent qapi header refactoring? >> >=20 > Looks like it's not as simple.. >=20 > /tmp/qemu-test/src/include/block/accounting.h:30:10: fatal error:=20 > qapi-types.h: No such file or directory > =C2=A0#include "qapi-types.h >=20 >=20 > what to do now? Looks like qapi-types are not generated for some builds= .=20 > So, this version (v4) should take place. top-level qapi-types.h was replaced by lots of qapi/qapi*.h modular=20 headers. Unfortunately, incremental builds don't delete the stale=20 qapi-types.h that was left in tree from the point prior to the qapi=20 header refactoring. To get uint64List, use qapi/qapi-builtin-types.h. To get any type=20 defined in a qapi/MODULE.json file, use qapi/qapi-MODULE-types.h. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org