From: "Cédric Le Goater" <clg@kaod.org>
To: Chalapathi V <chalapathi.v@linux.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, fbarrat@linux.ibm.com, npiggin@gmail.com,
calebs@us.ibm.com, chalapathi.v@ibm.com,
saif.abrar@linux.ibm.com, dantan@us.ibm.com,
milesg@linux.ibm.com
Subject: Re: [PATCH v5 1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h
Date: Wed, 26 Jun 2024 11:09:30 +0200 [thread overview]
Message-ID: <6eeecfe5-941c-43f2-bda4-7bc19c40ccaa@kaod.org> (raw)
In-Reply-To: <20240626090528.812-2-chalapathi.v@linux.ibm.com>
On 6/26/24 11:05 AM, Chalapathi V wrote:
> In this commit target specific dependency from include/hw/ppc/pnv_xscom.h
> has been removed so that pnv_xscom.h can be included outside hw/ppc.
>
> Signed-off-by: Chalapathi V <chalapathi.v@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
> ---
> include/hw/ppc/pnv_xscom.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index 6209e18492..c8dd42bffd 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -21,9 +21,9 @@
> #define PPC_PNV_XSCOM_H
>
> #include "exec/memory.h"
> -#include "hw/ppc/pnv.h"
>
> typedef struct PnvXScomInterface PnvXScomInterface;
> +typedef struct PnvChip PnvChip;
>
> #define TYPE_PNV_XSCOM_INTERFACE "pnv-xscom-interface"
> #define PNV_XSCOM_INTERFACE(obj) \
next prev parent reply other threads:[~2024-06-26 9:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 9:05 [PATCH v5 0/6] hw/ppc: SPI model Chalapathi V
2024-06-26 9:05 ` [PATCH v5 1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h Chalapathi V
2024-06-26 9:09 ` Cédric Le Goater [this message]
2024-06-26 12:10 ` CALEB SCHLOSSIN
2024-06-26 9:05 ` [PATCH v5 2/6] hw/ssi: Add SPI model Chalapathi V
2024-06-27 2:50 ` CALEB SCHLOSSIN
2024-06-27 7:29 ` Cédric Le Goater
2024-06-27 15:04 ` Miles Glenn
2024-06-26 9:05 ` [PATCH v5 3/6] hw/ssi: Extend " Chalapathi V
2024-06-27 2:54 ` CALEB SCHLOSSIN
2024-06-27 15:05 ` Miles Glenn
2024-06-26 9:05 ` [PATCH v5 4/6] hw/block: Add Microchip's 25CSM04 to m25p80 Chalapathi V
2024-06-26 9:05 ` [PATCH v5 5/6] hw/ppc: SPI controller wiring to P10 chip Chalapathi V
2024-06-26 9:05 ` [PATCH v5 6/6] tests/qtest: Add pnv-spi-seeprom qtest Chalapathi V
2024-06-27 2:56 ` CALEB SCHLOSSIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eeecfe5-941c-43f2-bda4-7bc19c40ccaa@kaod.org \
--to=clg@kaod.org \
--cc=calebs@us.ibm.com \
--cc=chalapathi.v@ibm.com \
--cc=chalapathi.v@linux.ibm.com \
--cc=dantan@us.ibm.com \
--cc=fbarrat@linux.ibm.com \
--cc=milesg@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=saif.abrar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).