From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-block@nongnu.org
Subject: Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers
Date: Mon, 17 May 2021 15:19:02 -0400 [thread overview]
Message-ID: <6ef11e42-7778-762a-f11b-d88f1b688db3@redhat.com> (raw)
In-Reply-To: <20210517183954.1223193-1-philmd@redhat.com>
On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote:
> Missing review: #1
>
> Hi,
>
> The floppy disc controllers pulls in irrelevant devices (sysbus in
> an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
>
> This series clean that by extracting each device in its own file,
> adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.
>
> Since v3:
> - Fix ISA_SUPERIO -> FDC Kconfig dependency (jsnow)
>
> Since v2:
> - rebased
>
> Since v1:
> - added missing "hw/block/block.h" header (jsnow)
> - inlined hardware specific calls (Mark)
> - added R-b/A-b tags
>
> Regards,
>
> Phil.
>
> Philippe Mathieu-Daudé (9):
> hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC
> hw/block/fdc: Replace disabled fprintf() by trace event
> hw/block/fdc: Declare shared prototypes in fdc-internal.h
> hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c
> hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c
> hw/block/fdc: Add sysbus_fdc_init_drives() method
> hw/sparc/sun4m: Inline sun4m_fdctrl_init()
> hw/block/fdc-sysbus: Add 'dma-channel' property
> hw/mips/jazz: Inline fdctrl_init_sysbus()
>
> hw/block/fdc-internal.h | 156 +++++++++++
> include/hw/block/fdc.h | 7 +-
> hw/block/fdc-isa.c | 313 +++++++++++++++++++++
> hw/block/fdc-sysbus.c | 224 +++++++++++++++
> hw/block/fdc.c | 608 +---------------------------------------
> hw/mips/jazz.c | 16 ++
> hw/sparc/sun4m.c | 16 ++
> MAINTAINERS | 3 +
> hw/block/Kconfig | 8 +
> hw/block/meson.build | 2 +
> hw/block/trace-events | 3 +
> hw/i386/Kconfig | 2 +-
> hw/isa/Kconfig | 7 +-
> hw/mips/Kconfig | 2 +-
> hw/sparc/Kconfig | 2 +-
> hw/sparc64/Kconfig | 2 +-
> 16 files changed, 759 insertions(+), 612 deletions(-)
> create mode 100644 hw/block/fdc-internal.h
> create mode 100644 hw/block/fdc-isa.c
> create mode 100644 hw/block/fdc-sysbus.c
>
Hi, tentatively staged:
https://gitlab.com/jsnow/qemu/-/commits/floppy/
pending CI:
https://gitlab.com/jsnow/qemu/-/pipelines/304308461
--js
next prev parent reply other threads:[~2021-05-17 19:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 18:39 [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 1/9] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 2/9] hw/block/fdc: Replace disabled fprintf() by trace event Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 3/9] hw/block/fdc: Declare shared prototypes in fdc-internal.h Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 4/9] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 5/9] hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 6/9] hw/block/fdc: Add sysbus_fdc_init_drives() method Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 7/9] hw/sparc/sun4m: Inline sun4m_fdctrl_init() Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 8/9] hw/block/fdc-sysbus: Add 'dma-channel' property Philippe Mathieu-Daudé
2021-05-17 18:39 ` [PATCH v4 9/9] hw/mips/jazz: Inline fdctrl_init_sysbus() Philippe Mathieu-Daudé
2021-05-17 19:19 ` John Snow [this message]
2021-05-17 20:50 ` [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers Philippe Mathieu-Daudé
2021-05-17 21:11 ` John Snow
2021-05-18 7:14 ` Philippe Mathieu-Daudé
2021-05-22 6:51 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ef11e42-7778-762a-f11b-d88f1b688db3@redhat.com \
--to=jsnow@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).