From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CC04C4167B for ; Mon, 13 Nov 2023 16:08:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2ZSs-0007xE-HI; Mon, 13 Nov 2023 11:07:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2ZSq-0007wz-Sr for qemu-devel@nongnu.org; Mon, 13 Nov 2023 11:07:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2ZSm-00033A-I9 for qemu-devel@nongnu.org; Mon, 13 Nov 2023 11:07:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699891619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H0FUlj3f6tDnLI7GCuM1w2NSIFvel/178u6D1jD7Bbw=; b=Co7o30jyAtdaZiE2nsMuNNIctMglU1tTdeGTkMYhlz5ejf6rvuXUS4q71POCdBv4K2vYkh s/K5N93P+yvctUDR+6tlS2ZyIbhRqAkJuGdjZryx+vtbdZEMif9vp4RBSJcmkrzfxWCcoi tFqXKlkRyyM3/hku+6No/7EgqslN8Ic= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-qS45GbRqMC-pZgjiFbAFsA-1; Mon, 13 Nov 2023 11:06:57 -0500 X-MC-Unique: qS45GbRqMC-pZgjiFbAFsA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-67049a2c8b3so59189296d6.0 for ; Mon, 13 Nov 2023 08:06:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699891617; x=1700496417; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H0FUlj3f6tDnLI7GCuM1w2NSIFvel/178u6D1jD7Bbw=; b=v9/JY7lxdx4MSyOd7RQTrRRi64/7lUaihM3Ohfzyk9SQv8WrmkSy5knZtEJlj/uLg6 E3w1yxLfjlChBeXH2O2I5WMhJR5UZlkFLj/ZuFm2O2zHpMN9L9iPIdplwaFYm0o/4lop IrWLhW2ZkNu0ca7W7mLFvfa9AbiPUz+YufH75jggJ8y54Qn1zRTzdZD7DEBwuQmvYjq4 qUrwhX6Jic5sim2uqrGINAEhELTNtlh/XSv/t+Mi+mxb62vxjLvASU4OFgGO1EURbCI8 jIt/NNghgQLOmfhcHfjtNnnkxrveA3pKPYzflSomFn0kv4+dlvtUcFAXdV8M1KEC4DQY m+VQ== X-Gm-Message-State: AOJu0YzRq0QWlEESPg9ti+mlhY/oTdG4Na4flvspFgSOWq53WSHu7+9U rL5rJNAIY5xHR0XwgZ0q5Zpp38CfZAEgOo1ATJdJrd0quuG+3tLxceTN4IFogVEHTwSMrRb1oIs fuL46TK9tuOibg2S7IJ23Igc= X-Received: by 2002:a05:6214:882:b0:66d:35b8:e661 with SMTP id cz2-20020a056214088200b0066d35b8e661mr7152714qvb.45.1699891617524; Mon, 13 Nov 2023 08:06:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiMFSiFfE0jHCyJ8dfz6ICWqgrEOCm2diIk3OPvZrsdX3a8NbOBb2NRoLyJkSBsDvCwiwFTw== X-Received: by 2002:a05:6214:882:b0:66d:35b8:e661 with SMTP id cz2-20020a056214088200b0066d35b8e661mr7152689qvb.45.1699891617293; Mon, 13 Nov 2023 08:06:57 -0800 (PST) Received: from [192.168.0.6] (ip-109-43-177-79.web.vodafone.de. [109.43.177.79]) by smtp.gmail.com with ESMTPSA id g1-20020a0cf841000000b00656329bb3b1sm2171472qvo.10.2023.11.13.08.06.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 08:06:57 -0800 (PST) Message-ID: <6ef83710-0e79-450e-a3da-5780f97430ac@redhat.com> Date: Mon, 13 Nov 2023 17:06:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] hw: Replace anti-social QOM type names (again) Content-Language: en-US To: Markus Armbruster , qemu-devel@nongnu.org Cc: alistair@alistair23.me, edgar.iglesias@gmail.com, peter.maydell@linaro.org, francisco.iglesias@amd.com, qemu-arm@nongnu.org, Tong Ho References: <20231113134344.1195478-1-armbru@redhat.com> <20231113134344.1195478-3-armbru@redhat.com> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20231113134344.1195478-3-armbru@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 13/11/2023 14.43, Markus Armbruster wrote: > QOM type names containing ',' result in awful UI. We got rid of them > in v6.0.0 (commit e178113ff64 hw: Replace anti-social QOM type names). > A few have crept back since: > > xlnx,cframe-reg > xlnx,efuse > xlnx,pmc-efuse-cache > xlnx,versal-cfu-apb > xlnx,versal-cfu-fdro > xlnx,versal-cfu-sfr > xlnx,versal-crl > xlnx,versal-efuse > xlnx,zynqmp-efuse > > These are all device types. They can't be plugged with -device / > device_add, except for "xlnx,efuse" (I'm not sure that one is > intentional). > > They *can* be used with -device / device_add to request help. > Usability is poor, though: you have to double the comma, like this: > > $ qemu-system-aarch64 -device xlnx,,pmc-efuse-cache,help > > They can also be used with -global, where you must *not* double the > comma: > > $ qemu-system-aarch64 -global xlnx,efuse.drive-index=2 > > Trap for the unwary. > > "xlnx,efuse", "xlnx,versal-efuse", "xlnx,pmc-efuse-cache", > "xlnx-zynqmp-efuse" are from v6.2.0, "xlnx,versal-crl" is from v7.1.0, > and the remainder are new. > > Rename them all to "xlnx-FOO", like commit e178113ff64 did. > > Reported-by: Thomas Huth > Signed-off-by: Markus Armbruster > --- > docs/system/arm/xlnx-versal-virt.rst | 2 +- > include/hw/misc/xlnx-versal-cframe-reg.h | 2 +- > include/hw/misc/xlnx-versal-cfu.h | 6 +++--- > include/hw/misc/xlnx-versal-crl.h | 2 +- > include/hw/nvram/xlnx-efuse.h | 2 +- > include/hw/nvram/xlnx-versal-efuse.h | 4 ++-- > include/hw/nvram/xlnx-zynqmp-efuse.h | 2 +- > 7 files changed, 10 insertions(+), 10 deletions(-) > Reviewed-by: Thomas Huth