qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH v2 3/3] iotests: Filter out ZFS in several tests
Date: Mon, 26 May 2025 11:42:24 +0200	[thread overview]
Message-ID: <6eff882f-0a71-456d-b3ff-16d82ec9b8ff@proxmox.com> (raw)
In-Reply-To: <20250523163041.2548675-8-eblake@redhat.com>

Am 23.05.25 um 18:27 schrieb Eric Blake:
> Fiona reported that ZFS makes sparse file testing awkward, since:
> - it has asynchronous allocation (not even 'fsync $file' makes du see
>   the desired size; it takes the slower 'fsync -f $file' which is not
>   appropriate for the tests)
> - for tests of fully allocated files, ZFS with compression enabled
>   still reports smaller disk usage
> 
> Add a new _require_sparse_file that quickly probes whether an attempt

It's called _require_disk_usage in the implementation.

> to create a sparse 5M file shows as less than 1M usage, while the same
> file with -o preallocation=full shows as more than 4M usage without
> sync, which should filter out ZFS behavior.  Then use it in various
> affected tests.
> 
> This does not add the new filter on all tests that Fiona is seeing ZFS
> failures on, but only those where I could quickly spot that there is
> at least one place where the test depends on the output of 'du -b' or
> 'stat -c %b'.
> 
> Reported-by: Fiona Ebner <f.ebner@proxmox.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>



  reply	other threads:[~2025-05-26  9:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 16:27 [PATCH v2 0/3] iotests improvements for mirror-sparse and others Eric Blake
2025-05-23 16:27 ` [PATCH v2 1/3] iotests: Use disk_usage in more places Eric Blake
2025-05-26  9:42   ` Fiona Ebner
2025-05-23 16:27 ` [PATCH v2 2/3] iotests: Improve mirror-sparse on ext4 Eric Blake
2025-05-23 17:11   ` Eric Blake
2025-05-28 15:45   ` Eric Blake
2025-05-28 18:32     ` Eric Blake
2025-05-28 18:47       ` Markus Armbruster
2025-05-23 16:27 ` [PATCH v2 3/3] iotests: Filter out ZFS in several tests Eric Blake
2025-05-26  9:42   ` Fiona Ebner [this message]
2025-05-27 13:24     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6eff882f-0a71-456d-b3ff-16d82ec9b8ff@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).