From: Maxim Levitsky <mlevitsk@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 3/4] device-core: use atomic_set on .realized property
Date: Mon, 11 May 2020 14:14:49 +0300 [thread overview]
Message-ID: <6f02830942ac3d4812344d7ecfa1841fa668c177.camel@redhat.com> (raw)
In-Reply-To: <82d51a76-fd38-d72e-2d22-c4de1a76d5f9@redhat.com>
On Mon, 2020-05-11 at 13:11 +0200, Paolo Bonzini wrote:
> On 11/05/20 13:00, Maxim Levitsky wrote:
> > On second thought, I think both cases matter, after I examined the device removal case.
> > In device removal case, the device is first un-realized and then removed from the bus,
> > so just like in device hotplug case, the scsi_device_find can give you an unrealized device.
> >
> > I will change this patch to set .realized to false at the start (if needed) of the function and to true at the end (also if needed)
> > Will atomic_rcu_set work? or atomic_store_release?
> > (Both are the same thing, but former documents the purpose of using with RCU.
>
> atomic_rcu_set is more to store pointers, in this case you want to store
> the value after any other change to the struct so atomic_store_release
> is more appropriate.
>
> Paolo
>
All right then.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2020-05-11 11:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 20:36 [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread Maxim Levitsky
2020-04-16 20:36 ` [PATCH 1/4] scsi/scsi_bus: switch search direction in scsi_device_find Maxim Levitsky
2020-04-16 20:36 ` [PATCH 2/4] device-core: use RCU for list of childs of a bus Maxim Levitsky
2020-05-04 10:41 ` Stefan Hajnoczi
2020-05-11 8:48 ` Maxim Levitsky
2020-04-16 20:36 ` [PATCH 3/4] device-core: use atomic_set on .realized property Maxim Levitsky
2020-05-04 10:45 ` Stefan Hajnoczi
2020-05-04 11:22 ` Paolo Bonzini
2020-05-04 11:36 ` Maxim Levitsky
2020-05-11 11:00 ` Maxim Levitsky
2020-05-11 11:11 ` Paolo Bonzini
2020-05-11 11:14 ` Maxim Levitsky [this message]
2020-04-16 20:36 ` [PATCH 4/4] virtio-scsi: don't touch scsi devices that are not yet realized Maxim Levitsky
2020-05-04 11:24 ` Paolo Bonzini
2020-05-11 11:21 ` Maxim Levitsky
2020-04-16 21:33 ` [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread no-reply
2020-04-16 21:35 ` no-reply
2020-04-16 21:47 ` no-reply
2020-05-04 10:59 ` Stefan Hajnoczi
2020-05-04 11:38 ` Paolo Bonzini
2020-05-04 11:43 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f02830942ac3d4812344d7ecfa1841fa668c177.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).