From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF74C433ED for ; Fri, 14 May 2021 08:15:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F6DE6135A for ; Fri, 14 May 2021 08:15:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F6DE6135A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhSyR-0003ap-3J for qemu-devel@archiver.kernel.org; Fri, 14 May 2021 04:15:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhSxn-0002w1-L5 for qemu-devel@nongnu.org; Fri, 14 May 2021 04:14:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhSxk-0001dB-Vg for qemu-devel@nongnu.org; Fri, 14 May 2021 04:14:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620980063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Fs3GU6DaSXGpo0a38oZ+0jyv8tLZi+P+hu5Cm5EraQ=; b=MB8MoZa3KvdrM0W9h7gaFm+Q0YS7F7Bzp8v7Rb7Ew0R9OaQy6XVEE5rxYcR/ZBPwTnV7w3 A0MGkBnHGzpCpn/3kwcrIHXyqEgzUSQ6CRUk/aXKNa7ohLeRF42rJejgAyScf8ch7OKKm+ S808gboq875db3CvUwBGRUrpdE0c43w= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-rqhHsZMCP2uHFoCerTPGsQ-1; Fri, 14 May 2021 04:14:22 -0400 X-MC-Unique: rqhHsZMCP2uHFoCerTPGsQ-1 Received: by mail-ed1-f71.google.com with SMTP id k10-20020a50cb8a0000b0290387e0173bf7so16097044edi.8 for ; Fri, 14 May 2021 01:14:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/Fs3GU6DaSXGpo0a38oZ+0jyv8tLZi+P+hu5Cm5EraQ=; b=Iyud3Q/I3oKKSYo5b9gQRHI/VprXgpWQswnZBgCNowiJaYMIsVTpg43M9LodyVMTWX jMUxRMYZQJN6nU2qvFrk79CG0vnemfLhq0bYM7UFa1vw29qEvdbCuhUOAw/Ih7BM756c KWZaskzwEXySxq+HVb939d6jcMqSFhjwl9MRq2yEPboV3IcrbZ7kF0z1VXBXD0UwRgCp oKub2rPaiCwhzvg/mUycpBuX9YRF+K7Dak8HULGl5mGii17dHAIUPshI17SJufgTeAQ4 6OMIZRhPb767TWkmOKsSfTMXnyxn+YVtxVzIWNYH/6n9Gubpttap/XD1OTe3B5De1WpH 0DYQ== X-Gm-Message-State: AOAM530ieDbtW/hvdVLgU9/O+8/n7GNJB+NNFkuR34SFUmU+55/o5rhq yLirp6JI8WFcUAafdo1LCoJDJZNEx3ZU3jgDZwgilcA5ZfTTfBZELXzCWsTyFW1FcGopwJFNBO8 RZIeLc3h2b8KpnAk= X-Received: by 2002:aa7:d818:: with SMTP id v24mr10500517edq.290.1620980060944; Fri, 14 May 2021 01:14:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjzatgqLYyvIZOsGFvGbJsvZlBl6qHQIt8mZTRRf4oRTubZPKjrmD24pGckWk8MTFjGy66Ag== X-Received: by 2002:aa7:d818:: with SMTP id v24mr10500492edq.290.1620980060733; Fri, 14 May 2021 01:14:20 -0700 (PDT) Received: from [192.168.1.36] (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id c22sm3930173edy.59.2021.05.14.01.14.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 01:14:20 -0700 (PDT) Subject: Re: [PATCH 06/10] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL To: Bin Meng References: <20210513163858.3928976-1-philmd@redhat.com> <20210513163858.3928976-7-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <6f113d31-6c3d-eb5e-ceee-48e265e35876@redhat.com> Date: Fri, 14 May 2021 10:14:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V TCG CPUs" , Bin Meng , "qemu-devel@nongnu.org Developers" , Alistair Francis , Paolo Bonzini , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/14/21 4:47 AM, Bin Meng wrote: > Hi Philippe, > > On Fri, May 14, 2021 at 12:57 AM Philippe Mathieu-Daudé > wrote: >> >> Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART >> emulation") added a dependency on the SERIAL model, but forgot to >> add the Kconfig selector. Fix that to solve when built the >> MICROCHIP_PFSOC machine stand-alone: >> >> /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create': >> hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init' >> >> Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Cc: Bin Meng >> Cc: Alistair Francis >> --- >> hw/riscv/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig >> index 86957ec7b06..b72a248809e 100644 >> --- a/hw/riscv/Kconfig >> +++ b/hw/riscv/Kconfig >> @@ -12,6 +12,7 @@ config MICROCHIP_PFSOC >> select SIFIVE_CLINT >> select SIFIVE_PDMA >> select SIFIVE_PLIC >> + select SERIAL > > This dependency should be expressed by MCHP_PFSOC_MMUART in hw/char/Kconfig Oh I missed this symbol, good catch!