From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] target/ppc: Clean up local variable shadowing in kvm_arch_*_registers()
Date: Fri, 6 Oct 2023 11:55:21 +0200 [thread overview]
Message-ID: <6f175ff8-5c23-62ed-a909-4b60fa230545@redhat.com> (raw)
In-Reply-To: <20231006053526.1031252-1-clg@kaod.org>
On 06/10/2023 07.35, Cédric Le Goater wrote:
> Remove extra 'i' variable to fix this warning :
>
> ../target/ppc/kvm.c: In function ‘kvm_arch_put_registers’:
> ../target/ppc/kvm.c:963:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local]
> 963 | int i;
> | ^
> ../target/ppc/kvm.c:906:9: note: shadowed declaration is here
> 906 | int i;
> | ^
> ../target/ppc/kvm.c: In function ‘kvm_arch_get_registers’:
> ../target/ppc/kvm.c:1265:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local]
> 1265 | int i;
> | ^
> ../target/ppc/kvm.c:1212:9: note: shadowed declaration is here
> 1212 | int i, ret;
> | ^
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> target/ppc/kvm.c | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-10-06 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 5:35 [PATCH] target/ppc: Clean up local variable shadowing in kvm_arch_*_registers() Cédric Le Goater
2023-10-06 9:55 ` Thomas Huth [this message]
2023-10-06 10:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f175ff8-5c23-62ed-a909-4b60fa230545@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).