From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Alessandro Di Federico <ale@rev.ng>,
qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
Taylor Simpson <tsimpson@quicinc.com>,
Anton Johansson <anjo@rev.ng>,
philmd@linaro.org, bcain@quicinc.com, quic_mathbern@quicinc.com,
stefanha@redhat.com
Subject: Re: [PATCH] Update scripts/meson-buildoptions.sh
Date: Sun, 8 Jan 2023 17:59:19 -0800 [thread overview]
Message-ID: <6f26d23b-007e-2eb0-395c-0f46fa0fc316@linaro.org> (raw)
In-Reply-To: <8cf1e1ee-1e2a-d53f-3f8c-e870fe51f75d@redhat.com>
On 1/7/23 10:02, Paolo Bonzini wrote:
> On 1/3/23 20:31, Stefan Hajnoczi wrote:
>>> The other problem with this file is that it appears to
>>> be generated differently depending on the host distro
>>> (specifically the default value for the --libdir option).
>>> That also would seem to nudge towards "don't commit a
>>> generated file".
>
> I wasn't aware of the libdir default that Peter mentioned, but the same issue would happen
> for release tarballs so "do not commit it" would have to be extended to "do not ship it",
> that is do everything in Python.
>
> This in turn goes back to the reason for the buildoptions.sh approach: the path to the
> Python binary is not known when "configure --help" prints the help message. If the user
> does not have a python3 or meson binary in the path, requiring "configure --meson=...
> --help" or "configure --python=... --help" is not hideous I guess, but not pretty either.
I think an extremely early error message for missing python (and pointer to --python) is
perfectly reasonable. I imagine it would be very rare, a case of forgetting to install
all of the build dependencies into a fresh container.
r~
next prev parent reply other threads:[~2023-01-09 1:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 10:41 [PATCH] Update scripts/meson-buildoptions.sh Alessandro Di Federico via
2023-01-03 14:14 ` Thomas Huth
2023-01-03 14:37 ` Stefan Hajnoczi
2023-01-03 15:26 ` Alessandro Di Federico via
2023-01-03 15:51 ` Stefan Hajnoczi
2023-01-03 16:11 ` Alessandro Di Federico via
2023-01-03 17:30 ` Peter Maydell
2023-01-03 19:31 ` Stefan Hajnoczi
2023-01-07 18:02 ` Paolo Bonzini
2023-01-09 1:59 ` Richard Henderson [this message]
2023-01-04 14:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f26d23b-007e-2eb0-395c-0f46fa0fc316@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).