From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BF9DC77B76 for ; Sun, 23 Apr 2023 19:04:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqexD-0000HD-Ew; Sun, 23 Apr 2023 15:00:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqex5-00009v-5m for qemu-devel@nongnu.org; Sun, 23 Apr 2023 15:00:47 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqex3-0004Ob-JK for qemu-devel@nongnu.org; Sun, 23 Apr 2023 15:00:46 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-2fa0ce30ac2so3338372f8f.3 for ; Sun, 23 Apr 2023 12:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682276445; x=1684868445; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9uvrma150yzljMYYaGgTLVWzkYKkZURHEB81TVBTbbc=; b=t12lkK3Vx7Jph8kk8hgGvTq8p0X7foy25IbWfe5xnsX7z2OU+5FfVgMi27805iW5ls DRjl3qcVVIvXHcaifbj+E/nAxw0m5YXV1mF9cRjRt3aLD2TP2QP9yAW+RHi0BYlj2Rn0 YW3znhmbUquNGzYS2/7EjVVIqqTil4Wf/CqP6lSCManldgRqxXyA5cQNPFTV6h4AQPwQ KZugxsqJCdxXweQE+6lSauOLZhHBLMnocKXlscdV/pSBBsZgtqmUG/KbyEAtAqJ5S52t 7KV8EvqtLW9MBORPveuSqI1NGIJANAmf6yiIMEroGIzNDCqvNzfHQMxgEbq4uMjg8Fi+ jUwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682276445; x=1684868445; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9uvrma150yzljMYYaGgTLVWzkYKkZURHEB81TVBTbbc=; b=USDo5+wBonPsw7OWMeaR0YyX0fxrdSaQNdOxsmlgw+y8KJEIFDMXyLK+UHUgBiLjC1 Z21xDs2XrITonJVZRbh9uJv6sO6JV+1a/XJ0zLGsiYlb9CcnzQvuxOmf6hKpAVLJZZHU fThvnuJUzcVbb1cBJ3hb2T/N0TnQx8EkCfFWB3gRZ7JtT2j9AbDvcX2Qr1fV7Mx5WGL4 n7vTxyiKmCguHIiXXNb5iH9YpS2v5CBLo/J942loqSLALkzv/Ncq2e+im1PfRqFFN+dx cGnRlei4aEYlGhiyhIdonbL0B68/GxUZBMS5lp+Jqko0m/RgU0G0/mtvBuCjTdCMNyVX FxvA== X-Gm-Message-State: AAQBX9fxIayykXHqwjqV3MXXoEiye0z/RKARPmbLTAm9zUdzPO+Ghbud etR6tviJ/af16TjVhHe6fe5+6cH7tPLTYbyJ78cYLg== X-Google-Smtp-Source: AKy350bPJsDnihHKt49/IpdtWe8gMmRtqMfZ2yOmdpRsbr99MMkset/sBmlrRw+7cNo4Fz+UbCtKPA== X-Received: by 2002:adf:dc89:0:b0:2c9:e585:84b0 with SMTP id r9-20020adfdc89000000b002c9e58584b0mr7658645wrj.1.1682276444739; Sun, 23 Apr 2023 12:00:44 -0700 (PDT) Received: from [192.168.109.175] (119.red-88-28-13.dynamicip.rima-tde.net. [88.28.13.119]) by smtp.gmail.com with ESMTPSA id k6-20020a5d5246000000b002fe87e0706bsm9144310wrc.97.2023.04.23.12.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Apr 2023 12:00:44 -0700 (PDT) Message-ID: <6f54a97a-306d-f375-1fc2-8faaf848ecd0@linaro.org> Date: Sun, 23 Apr 2023 20:55:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 33/54] tcg: Introduce arg_slot_stk_ofs Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org References: <20230411010512.5375-1-richard.henderson@linaro.org> <20230411010512.5375-34-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230411010512.5375-34-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.143, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/4/23 03:04, Richard Henderson wrote: > Unify all computation of argument stack offset in one function. > This requires that we adjust ref_slot to be in the same units, > by adding max_reg_slots during init_call_layout. > > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) > +static inline int arg_slot_stk_ofs(unsigned arg_slot) > +{ > + unsigned max = TCG_STATIC_CALL_ARGS_SIZE / sizeof(tcg_target_long); static const? Regardless, Reviewed-by: Philippe Mathieu-Daudé > + unsigned stk_slot = arg_slot - ARRAY_SIZE(tcg_target_call_iarg_regs); > + > + tcg_debug_assert(stk_slot < max); > + return TCG_TARGET_CALL_STACK_OFFSET + stk_slot * sizeof(tcg_target_long); > +}