From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:60736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggugS-0000rM-E7 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:56:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggugQ-0006NI-KV for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:56:56 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:46914) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ggugQ-0006Ih-9y for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:56:54 -0500 References: <1546900184-27403-1-git-send-email-venu.busireddy@oracle.com> <1546900184-27403-2-git-send-email-venu.busireddy@oracle.com> From: Dongli Zhang Message-ID: <6f5632f5-1469-7000-9b92-ef2564a63f63@oracle.com> Date: Wed, 9 Jan 2019 00:56:38 +0800 MIME-Version: 1.0 In-Reply-To: <1546900184-27403-2-git-send-email-venu.busireddy@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/5] virtio_net: Add VIRTIO_NET_F_STANDBY feature bit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Venu Busireddy , si-wei.liu@oracle.com Cc: "Michael S. Tsirkin" , Marcel Apfelbaum , Sridhar Samudrala , qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org I am not familiar with libvirt and I would like to play with this only with qemu. With failover, we need to hotplug the VF on destination server to VM after live migration. However, the VF on destination server would have different mac address. How can we specify the mac for the new VF to hotplug via qemu, as VF is only a vfio pci device? I am trying to play with this with only qemu (w/o libvirt). Thank you very much! Dongli Zhang On 01/08/2019 06:29 AM, Venu Busireddy wrote: > From: Sridhar Samudrala > > This feature bit can be used by a hypervisor to indicate to the virtio_net > device that it can act as a standby for another device with the same MAC > address. > > Signed-off-by: Sridhar Samudrala > Signed-off-by: Venu Busireddy > --- > hw/net/virtio-net.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 385b1a0..411f8fb 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -2198,6 +2198,8 @@ static Property virtio_net_properties[] = { > true), > DEFINE_PROP_INT32("speed", VirtIONet, net_conf.speed, SPEED_UNKNOWN), > DEFINE_PROP_STRING("duplex", VirtIONet, net_conf.duplex_str), > + DEFINE_PROP_BIT64("standby", VirtIONet, host_features, VIRTIO_NET_F_STANDBY, > + false), > DEFINE_PROP_END_OF_LIST(), > }; > >