Re: [PATCH 6/6] tracetool: drop the probe "__nocheck__" wrapping

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 5/8/25 22:03, Daniel P. Berrangé wrote:
> Every generated inline probe function is wrapped with a
> trivial caller that has a hard-coded condition test:
> 
>    static inline void _nocheck__trace_test_wibble(void * context, int value)
>    {
>        tracepoint(qemu, test_wibble, context, value);
>    }
> 
>    static inline void trace_test_wibble(void * context, int value)
>    {
>      if (true) {
>          _nocheck__trace_test_wibble(context, value);
>      }
>    }
> 
> This was introduced for TCG probes back in
> 
>    864a2178: trace: [tcg] Do not generate TCG code to trace dynamically-disabled events
> 
> but is obsolete since
> 
>    126d4123 tracing: excise the tcg related from tracetool
> 
> This commit removes the wrapping such that we have
> 
>    static inline void trace_test_wibble(void * context, int value)
>    {
>        tracepoint(qemu, test_wibble, context, value);
>    }
> 
> The default build of qemu-system-x86_64 on Fedora with the
> 'log' backend, has its size reduced by 1 MB
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   scripts/tracetool/__init__.py |  1 -
>   scripts/tracetool/format/h.py | 16 +---------------
>   tests/tracetool/dtrace.h      | 18 ++----------------
>   tests/tracetool/ftrace.h      | 24 +++++-------------------
>   tests/tracetool/log.h         | 24 +++++-------------------
>   tests/tracetool/simple.h      | 18 ++----------------
>   tests/tracetool/syslog.h      | 24 +++++-------------------
>   tests/tracetool/ust.h         | 18 ++----------------
>   8 files changed, 22 insertions(+), 121 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>