From: David Hildenbrand <david@redhat.com>
To: Collin Walling <walling@linux.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: thuth@redhat.com, wangyanan55@huawei.com, philmd@linaro.org,
marcel.apfelbaum@gmail.com, eduardo@habkost.net,
armbru@redhat.com, Jiri Denemark <jdenemar@redhat.com>
Subject: Re: [PATCH v4] target/s390x: filter deprecated properties based on model expansion type
Date: Fri, 26 Jul 2024 21:57:31 +0200 [thread overview]
Message-ID: <6f7b3367-4f13-44f0-8a04-f2be798e7bd3@redhat.com> (raw)
In-Reply-To: <20240725183909.24144-1-walling@linux.ibm.com>
On 25.07.24 20:39, Collin Walling wrote:
> Currently, there is no way to execute the query-cpu-model-expansion
> command to retrieve a comprehenisve list of deprecated properties, as
> the result is dependent per-model. To enable this, the expansion output
> is modified as such:
>
> When reporting a "static" CPU model, the command will only show
> deprecated properties that are a subset of the model's *enabled*
> properties. This is more accurate than how the query was handled
> before, which blindly reported properties that were never introduced
> for certain models.
>
> When reporting a "full" CPU model, show the *entire* list of deprecated
> properties regardless if they are supported on the model. A full
> expansion outputs all known CPU model properties anyway, so it makes
> sense to report all deprecated properties here too. This allows
> management apps to query a single model (e.g. host) to acquire the
> full list of deprecated properties.
>
> Additionally, the @deprecated-props array has been moved from the
> CpuModelInfo struct to the CpuModelExpansionInfo struct, since the data
> did not belong in the former.
>
> Acked-by: David Hildenbrand <david@redhat.com>
> Suggested-by: Jiri Denemark <jdenemar@redhat.com>
> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> ---
>
Hmmm, this does not apply on current master ... maybe because Thomas
already merged part of it?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-07-26 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 18:39 [PATCH v4] target/s390x: filter deprecated properties based on model expansion type Collin Walling
2024-07-26 19:57 ` David Hildenbrand [this message]
2024-07-26 20:00 ` Collin Walling
2024-07-26 20:03 ` David Hildenbrand
2024-07-26 20:10 ` Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f7b3367-4f13-44f0-8a04-f2be798e7bd3@redhat.com \
--to=david@redhat.com \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=jdenemar@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).