From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYIqQ-0006TP-0e for qemu-devel@nongnu.org; Fri, 12 Aug 2016 16:14:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYIqJ-0005Vr-Ts for qemu-devel@nongnu.org; Fri, 12 Aug 2016 16:14:16 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYIqJ-0005Vn-MX for qemu-devel@nongnu.org; Fri, 12 Aug 2016 16:14:11 -0400 Received: by mail-wm0-x243.google.com with SMTP id o80so4880090wme.0 for ; Fri, 12 Aug 2016 13:14:11 -0700 (PDT) References: <1470858179-27754-1-git-send-email-davidkiarie4@gmail.com> <1470858179-27754-4-git-send-email-davidkiarie4@gmail.com> From: Valentine Sinitsyn Message-ID: <6f9e0cb7-19c9-84b4-07aa-546d28d2f875@gmail.com> Date: Sat, 13 Aug 2016 01:14:08 +0500 MIME-Version: 1.0 In-Reply-To: <1470858179-27754-4-git-send-email-davidkiarie4@gmail.com> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V1 3/4] hw/acpi: report IOAPIC on IVRS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie , qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, mst@redhat.com, pbonzini@redhat.com, ehabkost@redhat.com, peter.maydell@linaro.org On 11.08.2016 00:42, David Kiarie wrote: > Report IOAPIC via IVRS which effectively allows linux AMD-Vi > driver to enable interrupt remapping > > Signed-off-by: David Kiarie > --- > hw/i386/acpi-build.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 49bd183..da602c3 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -2615,6 +2615,8 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker) > * Refer to Spec - Table 95:IVHD Device Entry Type Codes(4-byte) > */ > build_append_int_noprefix(table_data, 0x0000001, 4); > + /* IOAPIC represented as an 8-byte entry. Spec v2.62 Tables 97 */ > + build_append_int_noprefix(table_data, 0x0100a000ff000048, 8); Nit: bit 3 in DTE Setting is reserved (Table 97 in the spec), while you set them all with 0xff. > > build_header(linker, table_data, (void *)(table_data->data + iommu_start), > "IVRS", table_data->len - iommu_start, 1, NULL, NULL); > Valentine