Re: [PATCH 2/5] qtest/qom-test: Shallow testing of qom-list / qom-get

[Steven Sistare <steven.sistare@oracle.com>]

On 7/25/2025 9:50 AM, Markus Armbruster wrote:
> This test traverses the QOM sub-tree rooted at /machine with a
> combination of qom-list and qom-get.  In my x86_64 testing, it runs
> almost 12000 QMP commands in 34 seconds.  With -m slow, we test more
> machines, and it takes almost 84000 commands in almost four minutes.
> 
> Since commit 3dd93992ffb (tests/qtest/qom-test: unit test for
> qom-list-get), the test traverses this tree a second time, with
> qom-list-get.  In my x86_64 testing, this takes some 200 QMP commands
> and around two seconds, and some 1100 in just under 12s with -m slow.
> 
> Traversing the entire tree is useful, because it exercise the QOM
> property getters.  Traversing it twice not so much.
> 
> Make the qom-list / qom-get test shallow unless -m slow is given:
> don't recurse.  Cuts the number of commands to around 600, and run
> time to under 5s for me.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   tests/qtest/qom-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
> index cb5dbfe329..40bdc3639f 100644
> --- a/tests/qtest/qom-test.c
> +++ b/tests/qtest/qom-test.c
> @@ -180,7 +180,7 @@ static void test_properties(QTestState *qts, const char *path, bool recurse)
>           links = g_slist_delete_link(links, links);
>       }
>       while (children) {
> -        test_properties(qts, children->data, true);
> +        test_properties(qts, children->data, g_test_slow());
>           g_free(children->data);
>           children = g_slist_delete_link(children, children);
>       }

Nice optimization.  These tests were annoyingly slow!

Reviewed-by: Steve Sistare <steven.sistare@oracle.com>