Re: [Qemu-devel] [PATCH v2 3/3] fix qmp/hmp query-memdev not reporting IDs of memory backends

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

On 01/10/2017 06:53 AM, Igor Mammedov wrote:
> Considering 'id' is mandatory for user_creatable objects/backends
> and user_creatable_add_type() always has it as an argument
> regardless of where from it is called CLI/monitor or QMP,
> Fix issue by adding 'id' property to hostmem backends and
> set it in user_creatable_add_type() for every object that
> implements 'id' property. Then later at query-memdev time
> get 'id' from object directly.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  include/sysemu/hostmem.h |  1 +
>  backends/hostmem.c       | 26 ++++++++++++++++++++++++++
>  docs/qmp-commands.txt    |  1 +
>  hmp.c                    |  5 +----
>  numa.c                   |  3 +++
>  qapi-schema.json         |  3 +++
>  qom/object_interfaces.c  |  6 ++++++
>  7 files changed, 41 insertions(+), 4 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]