From: Matthew Rosato <mjrosato@linux.ibm.com>
To: "Cédric Le Goater" <clg@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>
Subject: Re: [PATCH for-8.2] s390x: Convert DPRINTF to trace events
Date: Tue, 22 Aug 2023 10:54:40 -0400 [thread overview]
Message-ID: <6fa799e3-90bf-8a00-6d15-349be0f329d6@linux.ibm.com> (raw)
In-Reply-To: <20230804080415.56852-1-clg@redhat.com>
On 8/4/23 4:04 AM, Cédric Le Goater wrote:
> Output message are slightly modified to ease selection with wildcards
> and to report extra parameters.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/s390x/s390-pci-bus.c | 25 ++++++------------
> hw/s390x/s390-pci-inst.c | 48 ++++++++++++++---------------------
> target/s390x/kvm/kvm.c | 33 ++++++++----------------
> hw/s390x/trace-events | 17 +++++++++++++
> target/s390x/kvm/trace-events | 7 +++++
> 5 files changed, 62 insertions(+), 68 deletions(-)
Thanks for this, it has been on my todo list for a while. Message contents look fine, so with Thomas's minor nit:
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
prev parent reply other threads:[~2023-08-22 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 8:04 [PATCH for-8.2] s390x: Convert DPRINTF to trace events Cédric Le Goater
2023-08-14 16:02 ` Thomas Huth
2023-08-22 14:54 ` Matthew Rosato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa799e3-90bf-8a00-6d15-349be0f329d6@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=farman@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).