From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8717AEE4993 for ; Tue, 22 Aug 2023 14:55:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYSmS-0008IY-OO; Tue, 22 Aug 2023 10:54:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYSmR-0008IM-I7; Tue, 22 Aug 2023 10:54:51 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYSmO-0006Yi-Op; Tue, 22 Aug 2023 10:54:51 -0400 Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37MEn7VA017353; Tue, 22 Aug 2023 14:54:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=dyECuk/KkQoBCxwGONPo4JyyK7MfH0Dw6ow4Vdtb6NA=; b=YMhN0T/4lHAW7EUFuv9vBxtKNG6swGvbkTm19V1nOpoP9tb7Bccr42SRkZGCtTCGuojT NyO9kxEdHhKKguUXySuLUkS3DhnVrMMWCGr45Kf5ER/jM/lA4zTTZqHqs7/3ioS2F5Us 6eygBFRPPFnoWb0G5iHnTtJZHK5hYXpEMjt4TH3WB5UQG22Kk6kijQpiHoThbV2xwVlw Xgn2rVocb0pZk38cvX69mMWaE4JNag2an9ei+2aq3L8LAVNQvw3jzBqAYlxiUJc5JnIp QrnmjZjWlZriQebu4GtEPE4eLqLhwuP2+IC+Ht1caGKkMbvO/qB1oGb0QZ763C4PhY4Z EQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3smy42g6xy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Aug 2023 14:54:43 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37MEnChM017780; Tue, 22 Aug 2023 14:54:43 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3smy42g6xa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Aug 2023 14:54:42 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37MEEhLt007184; Tue, 22 Aug 2023 14:54:42 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3smak7g520-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Aug 2023 14:54:42 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37MEsftJ1311286 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Aug 2023 14:54:41 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 54DAB5805E; Tue, 22 Aug 2023 14:54:41 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C21EC58055; Tue, 22 Aug 2023 14:54:40 +0000 (GMT) Received: from [9.61.174.59] (unknown [9.61.174.59]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 22 Aug 2023 14:54:40 +0000 (GMT) Message-ID: <6fa799e3-90bf-8a00-6d15-349be0f329d6@linux.ibm.com> Date: Tue, 22 Aug 2023 10:54:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH for-8.2] s390x: Convert DPRINTF to trace events Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Thomas Huth , Christian Borntraeger , Eric Farman References: <20230804080415.56852-1-clg@redhat.com> From: Matthew Rosato In-Reply-To: <20230804080415.56852-1-clg@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3vd-yYRsCFbxzol0YnEUIK6U09Usme1x X-Proofpoint-ORIG-GUID: seQ-oiAdVfvG40VnzKepzroFGy4kFsLE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-22_13,2023-08-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308220110 Received-SPF: pass client-ip=148.163.158.5; envelope-from=mjrosato@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.767, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/4/23 4:04 AM, Cédric Le Goater wrote: > Output message are slightly modified to ease selection with wildcards > and to report extra parameters. > > Signed-off-by: Cédric Le Goater > --- > hw/s390x/s390-pci-bus.c | 25 ++++++------------ > hw/s390x/s390-pci-inst.c | 48 ++++++++++++++--------------------- > target/s390x/kvm/kvm.c | 33 ++++++++---------------- > hw/s390x/trace-events | 17 +++++++++++++ > target/s390x/kvm/trace-events | 7 +++++ > 5 files changed, 62 insertions(+), 68 deletions(-) Thanks for this, it has been on my todo list for a while. Message contents look fine, so with Thomas's minor nit: Reviewed-by: Matthew Rosato