From: Richard Henderson <richard.henderson@linaro.org>
To: shihpo.hung@sifive.com, qemu-riscv@nongnu.org
Cc: Alistair Francis <Alistair.Francis@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
qemu-devel@nongnu.org,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Subject: Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status
Date: Tue, 14 Jan 2020 05:29:39 -1000 [thread overview]
Message-ID: <6fb13179-c56b-8270-5c64-06ba1d05943e@linaro.org> (raw)
In-Reply-To: <1578996840-14863-1-git-send-email-shihpo.hung@sifive.com>
On 1/14/20 12:13 AM, shihpo.hung@sifive.com wrote:
> if (riscv_cpu_fp_enabled(env)) {
> - *flags |= TB_FLAGS_MSTATUS_FS;
> + *flags |= env->mstatus & MSTATUS_FS;
> }
Note that riscv_cpu_fp_enabled is *also* testing env->mstatus, and that this
assignment can be made unconditional.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-01-14 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 10:13 [PATCH v2 1/3] target/riscv: Fix tb->flags FS status shihpo.hung
2020-01-14 10:13 ` [PATCH v2 2/3] target/riscv: fsd/fsw doesn't dirty FP state shihpo.hung
2020-01-14 15:48 ` Richard Henderson
2020-01-14 10:14 ` [PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty shihpo.hung
2020-01-14 15:47 ` Richard Henderson
2020-01-14 15:29 ` Richard Henderson [this message]
2020-01-15 6:16 ` [PATCH v2 1/3] target/riscv: Fix tb->flags FS status ShihPo Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb13179-c56b-8270-5c64-06ba1d05943e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=shihpo.hung@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).