qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	qemu-arm@nongnu.org, "Eric Blake" <eblake@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>, "Fam Zheng" <famz@redhat.com>,
	"QEMU Trivial" <qemu-trivial@nongnu.org>,
	"Alexander Graf" <agraf@suse.de>, qemu-ppc <qemu-ppc@nongnu.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alberto Garcia" <berto@igalia.com>,
	qemu-block@nongnu.org, "Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Yongbok Kim" <yongbok.kim@mips.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] Remove unnecessary variables for function return value
Date: Thu, 22 Mar 2018 17:58:17 +0100	[thread overview]
Message-ID: <6fd26097-aa7e-38cf-0d9e-09d0d36bd88b@redhat.com> (raw)
In-Reply-To: <CAMo8BfKkwM0wzX1yCBvwJ-Av4SZbgSrxmOGzD+Z_+bY0DTcgYg@mail.gmail.com>

On 22/03/2018 17:51, Max Filippov wrote:
> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier <lvivier@redhat.com> wrote:
>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>>  target/xtensa/core-dc232b/xtensa-modules.c         | 56 ++++++----------------
>>  target/xtensa/core-dc233c/xtensa-modules.c         | 56 ++++++----------------
>>  target/xtensa/core-de212/xtensa-modules.c          | 48 +++++--------------
>>  target/xtensa/core-fsf/xtensa-modules.c            | 32 ++++---------
>>  .../xtensa/core-sample_controller/xtensa-modules.c | 24 +++-------
> 
> These files were autogenerated, fixing them doesn't make much sense.

Good to know. They have been already updated by a couple of patches:

8f0a3716e4 Clean up includes
d8e39b7062 Use #include "..." for our own headers, <...> for others

Perhaps import_core.sh can be updated?

Thanks,
Laurent

  reply	other threads:[~2018-03-22 16:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 16:12 [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle Laurent Vivier
2018-03-22 16:12 ` [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again again) Laurent Vivier
2018-03-22 16:12 ` [Qemu-devel] [PATCH 2/4] error: Remove NULL checks on error_propagate() calls Laurent Vivier
2018-03-23 20:50   ` Eric Blake
2018-03-26  8:40     ` Laurent Vivier
2018-03-22 16:12 ` [Qemu-devel] [PATCH 3/4] qdict: remove useless cast Laurent Vivier
2018-03-22 16:23   ` Dr. David Alan Gilbert
2018-03-27  3:01   ` Fam Zheng
2018-03-22 16:12 ` [Qemu-devel] [PATCH 4/4] Remove unnecessary variables for function return value Laurent Vivier
2018-03-22 16:45   ` Eric Blake
2018-03-22 16:51   ` Max Filippov
2018-03-22 16:58     ` Laurent Vivier [this message]
2018-03-22 17:19       ` Max Filippov
2018-03-22 17:23         ` Peter Maydell
2018-03-22 17:26           ` Max Filippov
2018-03-22 17:30         ` Eric Blake
2018-03-22 17:40           ` Peter Maydell
2018-03-22 16:59     ` Eric Blake
2018-03-22 17:06       ` Max Filippov
2018-03-22 23:06   ` David Gibson
2018-03-23  2:14   ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-03-23 10:44   ` [Qemu-devel] " Alberto Garcia
2018-03-22 16:27 ` [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle Eric Blake
2018-03-22 16:45 ` Eric Blake
2018-03-22 17:57 ` no-reply
2018-03-22 18:00   ` Peter Maydell
2018-03-22 19:12     ` Eric Blake
2018-03-22 19:17       ` Peter Maydell
2018-03-23 12:37 ` Michael Tokarev
2018-03-23 12:40   ` Laurent Vivier
2018-03-23 17:42   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fd26097-aa7e-38cf-0d9e-09d0d36bd88b@redhat.com \
    --to=lvivier@redhat.com \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=berto@igalia.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=i.mitsyanko@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=yongbok.kim@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).