From: Thomas Huth <thuth@redhat.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>, qemu-devel@nongnu.org
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 4/4] configure: Test if $make actually exists
Date: Mon, 12 Oct 2020 11:49:54 +0200 [thread overview]
Message-ID: <6fdd2caf-7362-29db-9484-c1115297f5fa@redhat.com> (raw)
In-Reply-To: <20200825202755.50626-5-r.bolshakov@yadro.com>
On 25/08/2020 22.27, Roman Bolshakov wrote:
> configure doesn't detect if $make is installed on the build host.
> This is also helpful for hosts where an alias for make is used, i.e.
> configure would fail if gmake is not present on macOS.
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
> configure | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/configure b/configure
> index 664084992b..9230832da2 100755
> --- a/configure
> +++ b/configure
> @@ -2029,6 +2029,10 @@ if test -z "$python"
> then
> error_exit "Python not found. Use --python=/path/to/python"
> fi
> +if ! has "$make"
> +then
> + error_exit "GNU make ($make) not found"
> +fi
>
> # Note that if the Python conditional here evaluates True we will exit
> # with status 1 which is a shell 'false' value.
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-10-12 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 20:27 [PATCH v2 0/4] Compatibility make fixes for meson Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 1/4] configure: Use discovered make for in-source build Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 2/4] Makefile: Require GNU make 3.82+ Roman Bolshakov
2020-10-12 9:47 ` Thomas Huth
2020-12-13 17:21 ` Laurent Vivier
2020-12-13 19:04 ` Peter Maydell
2020-12-13 22:56 ` Laurent Vivier
2020-12-14 13:46 ` Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 3/4] configure: Prefer gmake on darwin Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 4/4] configure: Test if $make actually exists Roman Bolshakov
2020-10-12 9:49 ` Thomas Huth [this message]
2020-12-13 17:22 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fdd2caf-7362-29db-9484-c1115297f5fa@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).