From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF7CC433E7 for ; Mon, 12 Oct 2020 09:51:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0969720776 for ; Mon, 12 Oct 2020 09:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dGzIEd8z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0969720776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRuUn-0004ms-Qt for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 05:51:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRuSz-0003ww-Rv for qemu-devel@nongnu.org; Mon, 12 Oct 2020 05:50:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kRuSx-0001gL-C6 for qemu-devel@nongnu.org; Mon, 12 Oct 2020 05:50:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602496201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=52rPvKeqpDwL/qRi5rCEO1P2nbJLMSkvaCLzETAcPSE=; b=dGzIEd8zbGBpQE5QZnA9hd5LBYT31tE1U30Hx5pCdAasZhJLOoaNPFm1prTijiEe1Dt9Ag ECMxrFqa2cgb7kC6C/LsEbkKcParyGmlLEZe9+3uQQS3fGKDRXRrfmGcvAcZ43vQpCpins C89YnDc5gFmGI7R9IDaSS12BHq3QyHc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-sV5a8uF2PeWvIVEDGgeikA-1; Mon, 12 Oct 2020 05:49:57 -0400 X-MC-Unique: sV5a8uF2PeWvIVEDGgeikA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A9BE10051A4; Mon, 12 Oct 2020 09:49:56 +0000 (UTC) Received: from thuth.remote.csb (ovpn-113-22.ams2.redhat.com [10.36.113.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73E536EF7B; Mon, 12 Oct 2020 09:49:55 +0000 (UTC) Subject: Re: [PATCH v2 4/4] configure: Test if $make actually exists To: Roman Bolshakov , qemu-devel@nongnu.org References: <20200825202755.50626-1-r.bolshakov@yadro.com> <20200825202755.50626-5-r.bolshakov@yadro.com> From: Thomas Huth Message-ID: <6fdd2caf-7362-29db-9484-c1115297f5fa@redhat.com> Date: Mon, 12 Oct 2020 11:49:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200825202755.50626-5-r.bolshakov@yadro.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/11 23:52:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Paolo Bonzini , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 25/08/2020 22.27, Roman Bolshakov wrote: > configure doesn't detect if $make is installed on the build host. > This is also helpful for hosts where an alias for make is used, i.e. > configure would fail if gmake is not present on macOS. > > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Roman Bolshakov > --- > configure | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index 664084992b..9230832da2 100755 > --- a/configure > +++ b/configure > @@ -2029,6 +2029,10 @@ if test -z "$python" > then > error_exit "Python not found. Use --python=/path/to/python" > fi > +if ! has "$make" > +then > + error_exit "GNU make ($make) not found" > +fi > > # Note that if the Python conditional here evaluates True we will exit > # with status 1 which is a shell 'false' value. > Reviewed-by: Thomas Huth