Re: [PATCH v2] qemu-iotests: fix pylint 2.8 consider-using-with error

[Max Reitz <mreitz@redhat.com>]

On 12.05.21 19:04, Max Reitz wrote:
> On 10.05.21 21:04, Emanuele Giuseppe Esposito wrote:
>> pylint 2.8 introduces consider-using-with error, suggesting
>> to use the 'with' block statement when possible.
>>
>> Modify all subprocess.Popen call to use the 'with' statement,
>> except the one in __init__ of QemuIoInteractive class, since
>> it is assigned to a class field and used in other methods.
>>
>> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
>> ---
>> v1 -> v2:
>> * fix indentation [Max]
>> * explain why we disabled the check in QemuIoInteractive's __init__ [Max]
> 
> Thanks!
> 
> Applied to my block branch:
> 
> https://github.com/XanClic/qemu/commits/block

I’ve just seen that the “# pylint: disable=consider-using-with” line 
causes a warning in pylint versions that don’t know that warning…

I’d like to squash this in:

> diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc
> index 7a6c0a9474..f2c0b522ac 100644
> --- a/tests/qemu-iotests/pylintrc
> +++ b/tests/qemu-iotests/pylintrc
> @@ -19,6 +19,9 @@ disable=invalid-name,
>          too-many-public-methods,
>          # pylint warns about Optional[] etc. as unsubscriptable in 3.9
>          unsubscriptable-object,
> +        # Sometimes we need to disable a newly introduced pylint warning.
> +        # Doing so should not produce a warning in older versions of pylint.
> +        bad-option-value,
>          # These are temporary, and should be removed:
>          missing-docstring,
>          too-many-return-statements,

Would that be OK for you?

Max