From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-error: remove dependency of stubs on monitor
Date: Mon, 24 Oct 2016 16:36:14 +0200 [thread overview]
Message-ID: <6fed01cb-d6c6-8216-74c5-f0542a85f8ba@redhat.com> (raw)
In-Reply-To: <87ziltbzi7.fsf@dusky.pond.sub.org>
On 24/10/2016 16:19, Markus Armbruster wrote:
> cur_mon is semantically thread-local: it's non-null while we're
> executing a monitor command. That's a property of the stack, thus the
> thread. The fact that it's not actually thread-local now is a bug I
> blame on inertia.
Or just not noticing it until now.
> Further evidence: if a thread calls error_report(), it should honor
> cur_mon *only* when *this* thread executes a monitor command. It should
> not spew to some unrelated monitor just because some other thread
> happens to execute a monitor command right now.
Yes, that makes sense. I'll work on redoing David's patch on top of
this one then.
Paolo
next prev parent reply other threads:[~2016-10-24 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 9:33 [Qemu-devel] [PATCH] qemu-error: remove dependency of stubs on monitor Paolo Bonzini
2016-10-24 10:34 ` Dr. David Alan Gilbert
2016-10-24 11:52 ` Paolo Bonzini
2016-10-24 13:08 ` Markus Armbruster
2016-10-24 13:17 ` Paolo Bonzini
2016-10-24 14:19 ` Markus Armbruster
2016-10-24 14:36 ` Paolo Bonzini [this message]
2016-10-24 13:19 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fed01cb-d6c6-8216-74c5-f0542a85f8ba@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).