From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bygMS-0002ol-2g for qemu-devel@nongnu.org; Mon, 24 Oct 2016 10:36:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bygMO-0008CV-Bk for qemu-devel@nongnu.org; Mon, 24 Oct 2016 10:36:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54042) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bygMO-0008C5-64 for qemu-devel@nongnu.org; Mon, 24 Oct 2016 10:36:20 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CBFB8123D for ; Mon, 24 Oct 2016 14:36:19 +0000 (UTC) References: <1477301639-386-1-git-send-email-pbonzini@redhat.com> <20161024103400.GA4014@work-vm> <37942764-b3c8-1ac1-5121-894ada7300f2@redhat.com> <87vawhevxp.fsf@dusky.pond.sub.org> <477e068b-d445-2296-25c6-976be1e2e319@redhat.com> <87ziltbzi7.fsf@dusky.pond.sub.org> From: Paolo Bonzini Message-ID: <6fed01cb-d6c6-8216-74c5-f0542a85f8ba@redhat.com> Date: Mon, 24 Oct 2016 16:36:14 +0200 MIME-Version: 1.0 In-Reply-To: <87ziltbzi7.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-error: remove dependency of stubs on monitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org On 24/10/2016 16:19, Markus Armbruster wrote: > cur_mon is semantically thread-local: it's non-null while we're > executing a monitor command. That's a property of the stack, thus the > thread. The fact that it's not actually thread-local now is a bug I > blame on inertia. Or just not noticing it until now. > Further evidence: if a thread calls error_report(), it should honor > cur_mon *only* when *this* thread executes a monitor command. It should > not spew to some unrelated monitor just because some other thread > happens to execute a monitor command right now. Yes, that makes sense. I'll work on redoing David's patch on top of this one then. Paolo