From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91110CCD184 for ; Tue, 14 Oct 2025 18:59:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8kF3-00028U-Cj; Tue, 14 Oct 2025 14:59:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8kF1-00028B-HQ for qemu-devel@nongnu.org; Tue, 14 Oct 2025 14:59:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8kEv-0004se-JW for qemu-devel@nongnu.org; Tue, 14 Oct 2025 14:59:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760468355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=y4SG/bNb9O+sXv7AAtN2BlImM9b4hwBGnebGLUgcuTE=; b=cCiOqeHGcDioqqe+YB7H+IVk3f0CvsUJbO1nGSxilZCyiTZdh0gmYOZFhkHohJJM9vYodC wSMlMo/4V1S8mOMLF/2IyCqRm4pKcR0VFyBcaU91vi8aaAGInToarvjESXdIzXTaE89iJ0 TFgWxYqhExbVJFTlsc0fZgx6SuqDwO4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-PQ7UjJp9OjqIb-VGx3MFrg-1; Tue, 14 Oct 2025 14:59:14 -0400 X-MC-Unique: PQ7UjJp9OjqIb-VGx3MFrg-1 X-Mimecast-MFC-AGG-ID: PQ7UjJp9OjqIb-VGx3MFrg_1760468353 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-401dbafbcfaso4562908f8f.1 for ; Tue, 14 Oct 2025 11:59:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760468353; x=1761073153; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y4SG/bNb9O+sXv7AAtN2BlImM9b4hwBGnebGLUgcuTE=; b=QYPnDeZHPaHbkQouytMb6UP/v1tGy4+dmimOjbMjOUVLSPtCmwKZGYqnQURJs8KQXC DD8IqbPsl/v5RitwI8+bD/+GEVVOh5Ov5DlUPcaK56yiRTqy6attIsk/UUeh7z2qBiWQ hvEs742MNYYVZZaOmCTIPety0n1gRhpTTl1fAp3Y6DhV+3t7i5enT4BOIjjaezLPB8/I Kbpy+bnhyyX1pSUPOmkeGTxPUMsT6H2EDgXidI9rQENX6qrYEjrhpwUcCBFFz9BjSwIa WUHTCFNzfEFp8zCqmO58/SHQpgElFCEFECgdV9ttnFeiZ6B56Z5YtZRR7kJ6FjpSNtR3 TPUg== X-Forwarded-Encrypted: i=1; AJvYcCXkcPtnttKYDaAuooRRR9MqnOmCl1VzQl3jukY7ySBCV2LncWBT+kJ7VsL7Mv/WM1vwIXBioPMFfVdD@nongnu.org X-Gm-Message-State: AOJu0YyQg5zFuNOtXki9cuKHjmenQXq9udtccxR/WyWX/ElJdXOZ5knS hCMWhIMGGwT94NIC52lPIHtQmD3J3DuL1vo0qdve/woksbepiY84zeyzpAHJ84T8JygafqEgs5g X/v0lwfrLvI1GGB6CDXWuep8RO0CnEX2F0zP2XKxkbr1oWAKt3D/MhluC X-Gm-Gg: ASbGncuMhpURAGZNdYYJTE9I7fqGsa0+dkbTods+EmFQ/723ljzClrvnCwRZ6u0HPeR 4vuSXp68GM7Yqo7dT+U9C7RuzJMMYufB7VW7WJ2PjPgL33mAhlhn+HVEelfnuBHm3lNFwQ5/QQi UWV7kmGMQJdllNHFHxQPTNNYnZPxF+N0ME1jm1DDQMtBKD1a5HUcd+8My2XXGTcCpnr4IKSjqBk MIZSgjvUy8tCKGvOlS3N46hcVBOw5dyZhfnfCDFG4qS4UoguzJ6EP87Ou3mOabo8V79xTKlt5qt 3j+AAADeZ1KEkPTMIySQbRTfa45XlSPtL8BZsx6UXTmM+ba4et5XFxKqXiJCeUV9NMcHwHDHsbC oJd7qiw== X-Received: by 2002:a5d:5d0b:0:b0:3ea:c893:95c6 with SMTP id ffacd0b85a97d-4266726c2fcmr14565944f8f.18.1760468353041; Tue, 14 Oct 2025 11:59:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlcLVWkJWWKZCA2l62HboAXZwNWhRTVog5YAwsd7nkr0WNuRO5+4GwPV5WEqRZTBFa0t9xdQ== X-Received: by 2002:a5d:5d0b:0:b0:3ea:c893:95c6 with SMTP id ffacd0b85a97d-4266726c2fcmr14565930f8f.18.1760468352606; Tue, 14 Oct 2025 11:59:12 -0700 (PDT) Received: from [192.168.0.7] (ltea-047-064-112-136.pools.arcor-ip.net. [47.64.112.136]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce582a9csm25117576f8f.12.2025.10.14.11.59.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Oct 2025 11:59:11 -0700 (PDT) Message-ID: <701600e9-651c-405a-b076-57883878bdef@redhat.com> Date: Tue, 14 Oct 2025 20:59:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/9] python: Install pygdbmi in meson's venv To: John Snow Cc: Gustavo Romero , Paolo Bonzini , qemu-devel@nongnu.org, alex.bennee@linaro.org, berrange@redhat.com, qemu-arm@nongnu.org References: <20251002020432.54443-1-gustavo.romero@linaro.org> <20251002020432.54443-3-gustavo.romero@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 14/10/2025 20.55, John Snow wrote: > On Tue, Oct 14, 2025 at 2:21 PM Thomas Huth wrote: >> >> On 14/10/2025 19.39, John Snow wrote: >>> On Wed, Oct 1, 2025 at 10:09 PM Gustavo Romero >>> wrote: >>>> >>>> The upcoming changes in the reverse_debugging functional test to remove >>>> Avocado as a dependency will require pygdbmi for interacting with GDB, >>>> so install it in meson's venv (located in the build dir's pyvenv/). >>>> >>>> Reviewed-by: Thomas Huth >>>> Signed-off-by: Gustavo Romero >>>> --- >>>> pythondeps.toml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/pythondeps.toml b/pythondeps.toml >>>> index 16fb2a989c..98e99e7900 100644 >>>> --- a/pythondeps.toml >>>> +++ b/pythondeps.toml >>>> @@ -33,3 +33,4 @@ sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" } >>>> >>>> [testdeps] >>>> qemu.qmp = { accepted = ">=0.0.3", installed = "0.0.3" } >>>> +pygdbmi = { accepted = ">=0.11.0.0", installed = "0.11.0.0" } >>>> -- >>>> 2.34.1 >>>> >>> >>> Do we need to vendor pygdbmi? Currently, mkvenv does not consult >>> online sources and so if this package is missing, pulling in testdeps >>> will fail. >> >> This is handled by the "check-venv" target which is called now when you do a >> "make check-functional". See: >> >> https://gitlab.com/qemu-project/qemu/-/commit/75b1786996c422878d09bd12f166004a7d32e459 >> >> Works fine for me, did you hit any issues here? >> >> Thomas > > Ah-ha. I am working on dropping qemu.qmp from the tree and had moved > this machinery into mkvenv.py - I didn't realize that the Makefile > invocation here passes `--online`. The core groups for mkvenv still > operate offline only, I didn't realize we let it go online for tests. > > Before these dependencies get more numerous: do we accept that "make > check" might only work if you are online, or do we want to enforce the > idea that "make check" should always work offline only? > > (like "make check" works offline and "make check-extras" may require > internet for deps?) "make check" works offline (it does not include "check-functional"). It's only "make check-functional" that requires an internet connection. It required this for downloading the assets for the functional tests already, so adding "check-venv" here did not hurt. Thomas