* [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse
@ 2021-11-17 17:33 Richard Henderson
2021-11-17 18:12 ` Cédric Le Goater
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2021-11-17 17:33 UTC (permalink / raw)
To: qemu-devel; +Cc: alex.bennee, danielhb413, qemu-ppc, clg
With a host compiler new enough to recognize power10 insns,
CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu
option to the compiler, resulting in
/tmp/ccAVdYJd.s: Assembler messages:
/tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh'
/tmp/ccAVdYJd.s:78: Error: unrecognized opcode: `brw'
/tmp/ccAVdYJd.s:107: Error: unrecognized opcode: `brd'
make[2]: *** [byte_reverse] Error 1
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tests/tcg/ppc64le/Makefile.target | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tests/tcg/ppc64le/Makefile.target b/tests/tcg/ppc64le/Makefile.target
index 5e65b1590d..ba2fde5ff1 100644
--- a/tests/tcg/ppc64le/Makefile.target
+++ b/tests/tcg/ppc64le/Makefile.target
@@ -9,18 +9,12 @@ PPC64LE_TESTS=bcdsub
endif
bcdsub: CFLAGS += -mpower8-vector
-PPC64LE_TESTS += byte_reverse
ifneq ($(DOCKER_IMAGE)$(CROSS_CC_HAS_POWER10),)
+PPC64LE_TESTS += byte_reverse
+endif
+byte_reverse: CFLAGS += -mcpu=power10
run-byte_reverse: QEMU_OPTS+=-cpu POWER10
run-plugin-byte_reverse-with-%: QEMU_OPTS+=-cpu POWER10
-else
-byte_reverse:
- $(call skip-test, "BUILD of $@", "missing compiler support")
-run-byte_reverse:
- $(call skip-test, "RUN of byte_reverse", "not built")
-run-plugin-byte_reverse-with-%:
- $(call skip-test, "RUN of byte_reverse ($*)", "not built")
-endif
PPC64LE_TESTS += signal_save_restore_xer
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse
2021-11-17 17:33 [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse Richard Henderson
@ 2021-11-17 18:12 ` Cédric Le Goater
2021-11-17 18:14 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Cédric Le Goater @ 2021-11-17 18:12 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: alex.bennee, danielhb413, qemu-ppc
On 11/17/21 18:33, Richard Henderson wrote:
> With a host compiler new enough to recognize power10 insns,
> CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu
> option to the compiler, resulting in
>
> /tmp/ccAVdYJd.s: Assembler messages:
> /tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh'
> /tmp/ccAVdYJd.s:78: Error: unrecognized opcode: `brw'
> /tmp/ccAVdYJd.s:107: Error: unrecognized opcode: `brd'
> make[2]: *** [byte_reverse] Error 1
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This looks fine. Queued for 6.2
I would need some education on how to run these tests and reproduce.
Thanks,
C.
> ---
> tests/tcg/ppc64le/Makefile.target | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/tests/tcg/ppc64le/Makefile.target b/tests/tcg/ppc64le/Makefile.target
> index 5e65b1590d..ba2fde5ff1 100644
> --- a/tests/tcg/ppc64le/Makefile.target
> +++ b/tests/tcg/ppc64le/Makefile.target
> @@ -9,18 +9,12 @@ PPC64LE_TESTS=bcdsub
> endif
> bcdsub: CFLAGS += -mpower8-vector
>
> -PPC64LE_TESTS += byte_reverse
> ifneq ($(DOCKER_IMAGE)$(CROSS_CC_HAS_POWER10),)
> +PPC64LE_TESTS += byte_reverse
> +endif
> +byte_reverse: CFLAGS += -mcpu=power10
> run-byte_reverse: QEMU_OPTS+=-cpu POWER10
> run-plugin-byte_reverse-with-%: QEMU_OPTS+=-cpu POWER10
> -else
> -byte_reverse:
> - $(call skip-test, "BUILD of $@", "missing compiler support")
> -run-byte_reverse:
> - $(call skip-test, "RUN of byte_reverse", "not built")
> -run-plugin-byte_reverse-with-%:
> - $(call skip-test, "RUN of byte_reverse ($*)", "not built")
> -endif
>
> PPC64LE_TESTS += signal_save_restore_xer
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse
2021-11-17 18:12 ` Cédric Le Goater
@ 2021-11-17 18:14 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2021-11-17 18:14 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel; +Cc: alex.bennee, danielhb413, qemu-ppc
On 11/17/21 7:12 PM, Cédric Le Goater wrote:
> On 11/17/21 18:33, Richard Henderson wrote:
>> With a host compiler new enough to recognize power10 insns,
>> CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu
>> option to the compiler, resulting in
>>
>> /tmp/ccAVdYJd.s: Assembler messages:
>> /tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh'
>> /tmp/ccAVdYJd.s:78: Error: unrecognized opcode: `brw'
>> /tmp/ccAVdYJd.s:107: Error: unrecognized opcode: `brd'
>> make[2]: *** [byte_reverse] Error 1
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> This looks fine. Queued for 6.2
>
> I would need some education on how to run these tests and reproduce.
make check-tcg.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-17 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-17 17:33 [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse Richard Henderson
2021-11-17 18:12 ` Cédric Le Goater
2021-11-17 18:14 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).