From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36011)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T60JF-0000Zq-DJ
	for qemu-devel@nongnu.org; Mon, 27 Aug 2012 10:29:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T60JB-0007LT-8y
	for qemu-devel@nongnu.org; Mon, 27 Aug 2012 10:28:57 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:47971)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1T60JB-0007LJ-0Y
	for qemu-devel@nongnu.org; Mon, 27 Aug 2012 10:28:53 -0400
Date: Mon, 27 Aug 2012 10:28:38 -0400 (EDT)
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <703606518.14100692.1346077718872.JavaMail.root@redhat.com>
In-Reply-To: <CAFEAcA9NHk3wdExh=EaQRLs7=txF=3HXLRK+bxik1X8UuskUXA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: jan kiszka <jan.kiszka@siemens.com>, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, Eduardo Habkost <ehabkost@redhat.com>, xen-devel@lists.xensource.com, i mitsyanko <i.mitsyanko@samsung.com>, mdroth@linux.vnet.ibm.com, avi@redhat.com, anthony perard <anthony.perard@citrix.com>, lersek@redhat.com, stefanha@linux.vnet.ibm.com, stefano stabellini <stefano.stabellini@eu.citrix.com>, sw@weilnetz.de, lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de

----- Original Message -----
> From: "Peter Maydell" <peter.maydell@linaro.org>
...
> 
> I'm not objecting to this patch if it helps us move forwards,
> but adding the #include to sysemu.h is effectively just adding
> the definition to another grabbag header (183 files include
> sysemu.h). It would be nicer long-term to separate out the
> one thing in this header that cares about qemu_irq (the extern
> declaration of qemu_system_powerdown).
                 ^^^^
Is there a preference/suggestion in which header it should be declared?

...