From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Nikita Shubin" <nikita.shubin@maquefel.me>,
"Nikita Shubin" <n.shubin@yadro.com>
Cc: Mikhail Tyutin <m.tyutin@yadro.com>,
Aleksandr Anenkov <a.anenkov@yadro.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 01/12] gdbstub: Fix target_xml initialization
Date: Thu, 14 Sep 2023 14:29:45 +0200 [thread overview]
Message-ID: <703f0e35-128b-0c0c-4c8f-0fd182095d18@linaro.org> (raw)
In-Reply-To: <20230912224107.29669-2-akihiko.odaki@daynix.com>
On 13/9/23 00:40, Akihiko Odaki wrote:
> target_xml is no longer a fixed-length array but a pointer to a
> variable-length memory.
>
> Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> gdbstub/softmmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdbstub/softmmu.c b/gdbstub/softmmu.c
> index 9f0b8b5497..42645d2220 100644
> --- a/gdbstub/softmmu.c
> +++ b/gdbstub/softmmu.c
> @@ -292,7 +292,7 @@ static int find_cpu_clusters(Object *child, void *opaque)
> assert(cluster->cluster_id != UINT32_MAX);
> process->pid = cluster->cluster_id + 1;
> process->attached = false;
> - process->target_xml[0] = '\0';
> + process->target_xml = NULL;
>
> return 0;
> }
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-09-14 12:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 22:40 [PATCH v3 00/12] gdbstub and TCG plugin improvements Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 01/12] gdbstub: Fix target_xml initialization Akihiko Odaki
2023-09-14 12:29 ` Philippe Mathieu-Daudé [this message]
2023-09-12 22:40 ` [PATCH v3 02/12] gdbstub: Fix target.xml response Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 03/12] plugins: Check if vCPU is realized Akihiko Odaki
2023-09-13 6:17 ` Philippe Mathieu-Daudé
2023-09-14 17:16 ` Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 04/12] contrib/plugins: Use GRWLock in execlog Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 05/12] gdbstub: Introduce GDBFeature structure Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 06/12] target/arm: Move the reference to arm-core.xml Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 07/12] hw/core/cpu: Return static value with gdb_arch_name() Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 08/12] gdbstub: Use g_markup_printf_escaped() Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 09/12] target/arm: Remove references to gdb_has_xml Akihiko Odaki
2023-09-12 22:40 ` [PATCH v3 10/12] target/ppc: " Akihiko Odaki
2023-09-12 22:41 ` [PATCH v3 11/12] gdbstub: Remove gdb_has_xml variable Akihiko Odaki
2023-09-12 22:41 ` [PATCH v3 12/12] gdbstub: Replace gdb_regs with an array Akihiko Odaki
2023-09-14 15:56 ` [PATCH v3 00/12] gdbstub and TCG plugin improvements Alex Bennée
2023-09-14 17:18 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703f0e35-128b-0c0c-4c8f-0fd182095d18@linaro.org \
--to=philmd@linaro.org \
--cc=a.anenkov@yadro.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=m.tyutin@yadro.com \
--cc=n.shubin@yadro.com \
--cc=nikita.shubin@maquefel.me \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).