From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Alexander Bulekov <alxndr@bu.edu>,
qemu-block@nongnu.org
Subject: Re: [PATCH 1/7] ide: rename cmd_write to ctrl_write
Date: Fri, 24 Jul 2020 08:16:25 +0200 [thread overview]
Message-ID: <705b33b7-ec0d-99a0-e6e2-213c4ebddcfb@redhat.com> (raw)
In-Reply-To: <20200724052300.1163728-2-jsnow@redhat.com>
On 7/24/20 7:22 AM, John Snow wrote:
> It's the Control register, part of the Control block -- Command is
> misleading here. Rename all related functions and constants.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> include/hw/ide/internal.h | 9 +++++----
> hw/ide/core.c | 12 ++++++------
> hw/ide/ioport.c | 2 +-
> hw/ide/macio.c | 2 +-
> hw/ide/mmio.c | 8 ++++----
> hw/ide/pci.c | 12 ++++++------
> hw/ide/trace-events | 2 +-
> 7 files changed, 24 insertions(+), 23 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-07-24 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 5:22 [PATCH 0/7] IDE: SRST and other fixes John Snow
2020-07-24 5:22 ` [PATCH 1/7] ide: rename cmd_write to ctrl_write John Snow
2020-07-24 6:16 ` Philippe Mathieu-Daudé [this message]
2020-07-24 5:22 ` [PATCH 2/7] ide: don't tamper with the device register John Snow
2020-07-24 5:22 ` [PATCH 3/7] ide: model HOB correctly John Snow
2020-07-24 5:22 ` [PATCH 4/7] ide: reorder set/get sector functions John Snow
2020-07-24 6:17 ` Philippe Mathieu-Daudé
2020-07-24 5:22 ` [PATCH 5/7] ide: remove magic constants from the device register John Snow
2020-07-24 5:22 ` [PATCH 6/7] ide: clear interrupt on command write John Snow
2020-07-24 5:23 ` [PATCH 7/7] ide: cancel pending callbacks on SRST John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=705b33b7-ec0d-99a0-e6e2-213c4ebddcfb@redhat.com \
--to=philmd@redhat.com \
--cc=alxndr@bu.edu \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).