From: Tao Xu <tao3.xu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "ehabkost@redhat.com" <ehabkost@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Liu, Jingqi" <jingqi.liu@intel.com>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [PATCH RESEND v4 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE
Date: Sun, 29 Sep 2019 09:30:08 +0800 [thread overview]
Message-ID: <705e50fa-2d98-52ac-cdb7-1d68ca8f4b5d@intel.com> (raw)
In-Reply-To: <a1156a86-3ec3-da72-306b-1fafa0c369d7@redhat.com>
On 9/28/2019 4:22 AM, Paolo Bonzini wrote:
> On 18/09/19 09:23, Tao Xu wrote:
>> + } else if (function == 7 && index == 0 && reg == R_ECX) {
>> + if (enable_cpu_pm) {
>> + ret |= CPUID_7_0_ECX_WAITPKG;
>> + }
>
> This should be the opposite; remove the bit if enable_cpu_pm is not set.
>
> Paolo
>
Thanks, I will improve it.
next prev parent reply other threads:[~2019-09-29 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 7:23 [Qemu-devel] [PATCH RESEND v4 0/2] x86: Enable user wait instructions Tao Xu
2019-09-18 7:23 ` [Qemu-devel] [PATCH RESEND v4 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE Tao Xu
2019-09-27 20:22 ` Paolo Bonzini
2019-09-29 1:30 ` Tao Xu [this message]
2019-09-18 7:23 ` [Qemu-devel] [PATCH RESEND v4 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR Tao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=705e50fa-2d98-52ac-cdb7-1d68ca8f4b5d@intel.com \
--to=tao3.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=jingqi.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).