From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
qemu-arm@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 4/4] tests/qtest: Replace magic value by NANOSECONDS_PER_SECOND definition
Date: Mon, 12 Oct 2020 08:58:27 +0200 [thread overview]
Message-ID: <7067de64-2a42-07f5-a864-74d7524bee5f@redhat.com> (raw)
In-Reply-To: <20201011194918.3219195-5-f4bug@amsat.org>
On 11/10/2020 21.49, Philippe Mathieu-Daudé wrote:
> Use self-explicit NANOSECONDS_PER_SECOND definition instead
> of a magic value.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/qtest/rtc-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/rtc-test.c b/tests/qtest/rtc-test.c
> index c7af34f6b1b..402ce2c6090 100644
> --- a/tests/qtest/rtc-test.c
> +++ b/tests/qtest/rtc-test.c
> @@ -292,7 +292,7 @@ static void alarm_time(void)
> break;
> }
>
> - clock_step(1000000000);
> + clock_step(NANOSECONDS_PER_SECOND);
> }
>
> g_assert(get_irq(RTC_ISA_IRQ));
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2020-10-12 7:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 19:49 [PATCH 0/4] hw: Replace some magic by definitions Philippe Mathieu-Daudé
2020-10-11 19:49 ` [PATCH 1/4] hw: Replace magic value by PCI_NUM_PINS definition Philippe Mathieu-Daudé
2020-10-11 19:49 ` [PATCH 2/4] hw/pci-host/pam: Use ARRAY_SIZE() instead of magic value Philippe Mathieu-Daudé
2020-10-11 19:49 ` [PATCH 3/4] hw/pci-host/versatile: Add WINDOW_COUNT definition to replace magic '3' Philippe Mathieu-Daudé
2020-10-11 20:46 ` Peter Maydell
2020-10-12 13:01 ` Philippe Mathieu-Daudé
2020-10-11 19:49 ` [PATCH 4/4] tests/qtest: Replace magic value by NANOSECONDS_PER_SECOND definition Philippe Mathieu-Daudé
2020-10-12 6:58 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7067de64-2a42-07f5-a864-74d7524bee5f@redhat.com \
--to=thuth@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).