From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A60AAC433E0 for ; Thu, 18 Mar 2021 21:57:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EB0D64F3B for ; Thu, 18 Mar 2021 21:57:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EB0D64F3B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lN0dk-00048I-3R for qemu-devel@archiver.kernel.org; Thu, 18 Mar 2021 17:57:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lN0cx-0003af-QQ for qemu-devel@nongnu.org; Thu, 18 Mar 2021 17:56:23 -0400 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:45985) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lN0cw-0001Ia-2u for qemu-devel@nongnu.org; Thu, 18 Mar 2021 17:56:23 -0400 Received: by mail-ot1-x32a.google.com with SMTP id f73-20020a9d03cf0000b02901b4d889bce0so6613572otf.12 for ; Thu, 18 Mar 2021 14:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wWoxWk6iH+D7yn1pettTTwgNja5Zzig50vwkwOCThGg=; b=HSbvmRFWz0cRqYtH7QIMl3E40DUyVPCsB6giJJGduuxQ5r+EFOEoVmnV7WHN7nnok7 6s2MJ4usi2sYpC3HLdjJaSd9FiPKC0MP8IlDtZ8jlX4ry9jRoYLnuWtBpal6UkX6IMJ7 ZRvXr7G/0On7RFZFI2d7kSYbaizv3UkFuPYhw42btPPET9c6syKenzAjjWYtA5EVMrse +7KfcDLzv4J7trVOP17BRAqVltmknZGhgDZI6FvzCA89GzBgJJca71KiZ4t8TFu3vtNd iNor8Mo6LjvnC6r/6WrRYUKVmlv2F4v+hEvJ4iyzs5iajS656e5IJf36w1cUbDKG04MW gmnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wWoxWk6iH+D7yn1pettTTwgNja5Zzig50vwkwOCThGg=; b=qITq6hIzimblnHZpwACEQdMvvzM/EIm/ZFBGnPXcNefpqi/wwUui1YlhraDdC88haG PtZm9A9qKKZDHHZEVsVQ5f4kaieqXsej6+rkOo/VaiaIcvn6GZoss2HSscxLGZKhDpaC IzhwKplcziF0c/vDvNP/R0EX3bAKRMu1KIBUqfoErOoMTBoCpHtMkIHOHA627eVK4Q6x OURfcXnzruelhohjT/jPeL6lh3iDMnmgg0tkAVS4bioJ59Q2lQCzeYJeQI6DGUfO0tv5 a3KR3fGjtEe8E0NC1y5DtcXwXyhBSUBkkcjbFMoT3gkazPi0UDge/fVFteTA6ES/boyo G1wA== X-Gm-Message-State: AOAM532O5u4lZ5o8WiFuUbxJCJLVRmAxnOhZ+h1J6vULgugqyHGa7uXO DJ2yLWxtLFii+Loe6bGrOmNIPA== X-Google-Smtp-Source: ABdhPJyVudulg6Zz/HrwOFC/syWaPQSUjrJSL7G2hLSl+QxfDRjnTg67pjsOWZLyRFAbnROcsvTULg== X-Received: by 2002:a9d:6a0a:: with SMTP id g10mr9092512otn.236.1616104580356; Thu, 18 Mar 2021 14:56:20 -0700 (PDT) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id r22sm754334otg.4.2021.03.18.14.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 14:56:19 -0700 (PDT) Subject: Re: [PATCH for-6.0 v2 4/5] hw/core/loader: Add new function rom_ptr_for_as() To: Peter Maydell References: <20210318174823.18066-1-peter.maydell@linaro.org> <20210318174823.18066-5-peter.maydell@linaro.org> <176ca6cf-f917-eb5d-a5ce-d8a98db8fce4@linaro.org> From: Richard Henderson Message-ID: <706a2b95-f0ba-4abf-fdf7-09b7b856db45@linaro.org> Date: Thu, 18 Mar 2021 15:56:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::32a; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/18/21 3:28 PM, Peter Maydell wrote: > On Thu, 18 Mar 2021 at 21:14, Richard Henderson > wrote: >> >> On 3/18/21 1:02 PM, Peter Maydell wrote: >>>>> + * Note that we do not check @as against the 'as' member in the >>>>> + * 'struct Rom' returned by rom_ptr(). The Rom::as is the >>>>> + * AddressSpace which the rom blob should be written to... >> ... >>>> Should you really have this special case? Nowhere is this going to verify that >>>> @addr is in @as. >>> >>> It's the "happens almost all the time" case. Nothing verifies >>> that @addr is in @as anyway -- see the "Note that" part of the >>> comment above. >> >> The comment explains why we don't examine Rom::as. >> But we do check @addr vs @as via @as -> @fv -> flatview_translate. > > All we do is look for "every other address in the AS that > maps to the same MR as the address we started with". > Are you asking about the !cbdata.mr exit ? Well, I suppose. I guess I didn't read the cb properly. Reviewed-by: Richard Henderson r~