From: Laszlo Ersek <lersek@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: ANNOUNCE: build system conversion to Meson has landed
Date: Mon, 24 Aug 2020 12:56:08 +0200 [thread overview]
Message-ID: <706cd245-f5a5-9d3d-5ed9-fa7642534305@redhat.com> (raw)
In-Reply-To: <74116413-bd9d-b1a3-2364-26b7dcc7f105@redhat.com>
On 08/21/20 16:59, Paolo Bonzini wrote:
> On 21/08/20 16:50, Laszlo Ersek wrote:
>> On 08/21/20 15:49, Peter Maydell wrote:
>>
>>> https://wiki.qemu.org/Features/Meson/Next has a summary of changes
>>> and is worth a quick scan through.
>>
>> I'd like to propose a wording clarification:
>>
>> """
>> For bisection: incremental builds work fine in the forward direction.
>> They probably don't work at all backwards. This is mitigated by the fact
>> that bisection usually starts at a release, and the patches should be
>> applied on top of the 5.1.0 tag.
>> """
>>
>> namely:
>>
>> - s/forward direction/forward direction, across the conversion/
>> - s/backwards/backwards, across the conversion/
>>
>> Because the way the paragraph is worded now, it suggests that *any*
>> individual bisection step that moves backwards in the git history will
>> not build. That would be of course catastrophic. We should clarify that
>> the symptom is limited to steps that straddle the conversion commit range.
>>
>> If the suggested replacements are OK, I can make the edit myself (if
>> that's preferred).
>>
>> (Not trying to be a busybody -- exactly because I contribute little to
>> QEMU, bisection is a comparatively large part of what I *do* do with QEMU.)
>
> That's fine! I made a small adjustment and you're free to improve
> further on the wording.
Thanks a lot, the new text reads great!
Laszlo
prev parent reply other threads:[~2020-08-24 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 13:49 ANNOUNCE: build system conversion to Meson has landed Peter Maydell
2020-08-21 14:39 ` Eric Blake
2020-08-24 12:57 ` Markus Armbruster
2020-08-21 14:50 ` Laszlo Ersek
2020-08-21 14:59 ` Paolo Bonzini
2020-08-24 10:56 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=706cd245-f5a5-9d3d-5ed9-fa7642534305@redhat.com \
--to=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).