From: Paolo Bonzini <pbonzini@redhat.com>
To: "Mark Kanda" <mark.kanda@oracle.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH v2 1/3] qmp: Support for querying stats
Date: Wed, 19 Jan 2022 09:48:54 +0100 [thread overview]
Message-ID: <70842579-af1c-e633-0499-e865328bb466@redhat.com> (raw)
In-Reply-To: <347bc34f-178a-a260-9498-6be627b7537e@oracle.com>
On 1/18/22 14:59, Mark Kanda wrote:
> OK. Thank you Daniel and Paolo. I'll implement these changes for v3.
To clarify, the command should be
{ 'command': 'query-stats',
'data': 'StatsFilter',
'returns': 'StatsResults' }
so the "target" would be mandatory and there's one level less of nesting
in the arguments.
Paolo
next prev parent reply other threads:[~2022-01-19 9:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 19:51 [PATCH v2 0/3] Support fd-based KVM stats Mark Kanda
2021-11-19 19:51 ` [PATCH v2 1/3] qmp: Support for querying stats Mark Kanda
2021-12-07 18:42 ` Daniel P. Berrangé
2022-01-17 12:05 ` Paolo Bonzini
2022-01-17 15:17 ` Mark Kanda
2022-01-18 12:26 ` Paolo Bonzini
2022-01-18 12:52 ` Daniel P. Berrangé
2022-01-18 13:59 ` Mark Kanda
2022-01-19 8:48 ` Paolo Bonzini [this message]
2022-01-18 14:47 ` Igor Mammedov
2022-01-19 8:43 ` Paolo Bonzini
2022-01-19 9:11 ` Daniel P. Berrangé
2021-11-19 19:51 ` [PATCH v2 2/3] hmp: " Mark Kanda
2021-11-19 19:51 ` [PATCH v2 3/3] kvm: Support for querying fd-based stats Mark Kanda
2022-01-15 16:22 ` [PATCH v2 0/3] Support fd-based KVM stats Paolo Bonzini
2022-01-16 23:17 ` Mark Kanda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70842579-af1c-e633-0499-e865328bb466@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=mark.kanda@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).